[Java] Make detection of invalid names by language a warning and not an error. Issue #433.

Author: mjpt777

sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/XmlSchemaParser.java

@@ -303,17 +303,17 @@ public static void checkForValidName(final Node node, final String name)
     {
         if (!ValidationUtil.isSbeCppName(name))
         {
-            handleError(node, "name is not valid for C++: " + name);
+            handleWarning(node, "name is not valid for C++: " + name);
         }
 
         if (!ValidationUtil.isSbeJavaName(name))
         {
-            handleError(node, "name is not valid for Java: " + name);
+            handleWarning(node, "name is not valid for Java: " + name);
         }
 
         if (!ValidationUtil.isSbeGolangName(name))
         {
-            handleError(node, "name is not valid for Golang: " + name);
+            handleWarning(node, "name is not valid for Golang: " + name);
         }
     }
 

sbe-tool/src/test/java/uk/co/real_logic/sbe/xml/ErrorHandlerTest.java

@@ -92,8 +92,8 @@ public void shouldNotExitOnTypeErrorsAndWarnings()
         parseTestXmlAddToMap(map, "/types/enum", testXmlString, handler);
         parseTestXmlAddToMap(map, "/types/set", testXmlString, handler);
 
-        assertThat(valueOf(handler.errorCount()), is(valueOf(24)));
-        assertThat(valueOf(handler.warningCount()), is(valueOf(5)));
+        assertThat(valueOf(handler.errorCount()), is(valueOf(3)));
+        assertThat(valueOf(handler.warningCount()), is(valueOf(26)));
     }
 
     @Test
@@ -173,7 +173,7 @@ public void shouldExitInvalidFieldNames()
         throws Exception
     {
         exceptionRule.expect(IllegalStateException.class);
-        exceptionRule.expectMessage("had 12 errors");
+        exceptionRule.expectMessage("had 12 warnings");
 
         final ParserOptions options = ParserOptions.builder().suppressOutput(true).warningsFatal(true).build();