Skip to content

Commit 8b0b6ab

Browse files
committed
Added explicit children props as per new React 18 types
1 parent c49f30c commit 8b0b6ab

File tree

5 files changed

+22
-4
lines changed

5 files changed

+22
-4
lines changed

src/components/Centered.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
import * as React from "react";
22

3-
export const Centered: React.FC = (props) => <div className={`spaces-centered`}>{props.children}</div>;
3+
interface IProps {
4+
children?: React.ReactNode;
5+
}
6+
7+
export const Centered: React.FC<IProps> = (props) => <div className={`spaces-centered`}>{props.children}</div>;
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
11
import * as React from "react";
22

3-
export const CenteredVertically: React.FC = (props) => <div className={`spaces-centered-vertically`}>{props.children}</div>;
3+
interface IProps {
4+
children?: React.ReactNode;
5+
}
6+
7+
export const CenteredVertically: React.FC<IProps> = (props) => <div className={`spaces-centered-vertically`}>{props.children}</div>;

src/components/Layer.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@ import * as React from "react";
22
import { LayerContext } from "../core-react";
33
import * as PropTypes from "prop-types";
44

5-
export const Layer: React.FC<{ zIndex: number }> = (props) => <LayerContext.Provider value={props.zIndex}>{props.children}</LayerContext.Provider>;
5+
interface IProps {
6+
zIndex: number;
7+
children?: React.ReactNode;
8+
}
9+
10+
export const Layer: React.FC<IProps> = (props) => <LayerContext.Provider value={props.zIndex}>{props.children}</LayerContext.Provider>;
611

712
Layer.propTypes = {
813
zIndex: PropTypes.number.isRequired,

src/components/Options.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import * as React from "react";
22
import { IReactSpacesOptions, OptionsContext } from "../core-react";
33

4-
export const Options: React.FC<IReactSpacesOptions> = ({ children, ...opts }) => {
4+
interface IProps extends IReactSpacesOptions {
5+
children?: React.ReactNode;
6+
}
7+
8+
export const Options: React.FC<IProps> = ({ children, ...opts }) => {
59
return <OptionsContext.Provider value={opts}>{children}</OptionsContext.Provider>;
610
};

src/core-react.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ export interface IReactEvents {
5252
export interface IReactSpaceCommonProps extends ICommonProps, IReactEvents {
5353
style?: React.CSSProperties;
5454
as?: keyof React.ReactDOM | React.ComponentType<ICommonProps>;
55+
children?: React.ReactNode;
5556
}
5657

5758
export interface IReactSpaceInnerProps extends IReactSpaceCommonProps, ISpaceProps, IReactEvents {

0 commit comments

Comments
 (0)