Merge pull request #82 from aeagle/fix-overlayhandle-prop

Fix overlayhandle prop

Author: aeagle

.storybook/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "react-spaces-storybook",
-	"version": "0.1.28",
+	"version": "0.1.29",
 	"files": [
 		"**/*.*"
 	],

package-lock.json

@@ -1,6 +1,6 @@
 {
 	"name": "react-spaces",
-	"version": "0.1.28",
+	"version": "0.1.29",
 	"main": "dist/index.js",
 	"module": "dist/es/index.js",
 	"types": "dist/index.d.ts",

package.json

@@ -124,71 +124,40 @@ export const SpaceInternal: React.FC<AllProps> = React.memo((props) => {
 		onDoubleClick: props.onDoubleClick,
 	};
 
-	return props.resizable && props.scrollable
-		? React.createElement(
-				props.as || "div",
-				{
-					...{
-						id: space.id,
-						ref: spaceElement,
-						className: outerClasses.join(" "),
-					},
-					...passThroughEvents,
-				},
-				<>
-					<HeadStyles spaces={currentContext.children} />
-					<ResizeHandle
-						resizable={props.resizable}
-						anchor={props.anchor}
-						parentContext={parentContext}
-						space={space}
-						spaceElement={spaceElement.current}
-						minimumSize={props.minimumSize}
-						maximumSize={props.maximumSize}
-						onResizeStart={props.onResizeStart}
-						onResizeEnd={props.onResizeEnd}
-					/>
-					<div className={innerClasses.join(" ")} style={innerStyle}>
-						<SpaceContext.Provider value={currentContext}>
-							<SpaceInfoContext.Provider value={{ width: Math.floor(currentSize.width), height: Math.floor(currentSize.height) }}>
-								{children}
-							</SpaceInfoContext.Provider>
-						</SpaceContext.Provider>
-					</div>
-				</>,
-		  )
-		: React.createElement(
-				props.as || "div",
-				{
-					...{
-						id: space.id,
-						ref: spaceElement,
-						className: outerClasses.join(" "),
-						style: innerStyle,
-					},
-					...passThroughEvents,
-				},
-				<>
-					<HeadStyles spaces={currentContext.children} />
-					<ResizeHandle
-						resizable={props.resizable}
-						anchor={props.anchor}
-						parentContext={parentContext}
-						space={space}
-						handleSize={handleSize}
-						spaceElement={spaceElement.current}
-						minimumSize={props.minimumSize}
-						maximumSize={props.maximumSize}
-						onResizeStart={props.onResizeStart}
-						onResizeEnd={props.onResizeEnd}
-					/>
-					<SpaceContext.Provider value={currentContext}>
-						<SpaceInfoContext.Provider value={{ width: Math.floor(currentSize.width), height: Math.floor(currentSize.height) }}>
-							{children}
-						</SpaceInfoContext.Provider>
-					</SpaceContext.Provider>
-				</>,
-		  );
+	const width = Math.floor(currentSize.width);
+	const height = Math.floor(currentSize.height);
+
+	return React.createElement(
+		props.as || "div",
+		{
+			...{
+				id: space.id,
+				ref: spaceElement,
+				className: outerClasses.join(" "),
+			},
+			...passThroughEvents,
+		},
+		<>
+			<HeadStyles spaces={currentContext.children} />
+			<ResizeHandle
+				resizable={props.resizable}
+				anchor={props.anchor}
+				parentContext={parentContext}
+				space={space}
+				spaceElement={spaceElement.current}
+				handleSize={handleSize}
+				minimumSize={props.minimumSize}
+				maximumSize={props.maximumSize}
+				onResizeStart={props.onResizeStart}
+				onResizeEnd={props.onResizeEnd}
+			/>
+			<div className={innerClasses.join(" ")} style={innerStyle}>
+				<SpaceContext.Provider value={currentContext}>
+					<SpaceInfoContext.Provider value={{ width: width, height: height }}>{children}</SpaceInfoContext.Provider>
+				</SpaceContext.Provider>
+			</div>
+		</>,
+	);
 });
 
 SpaceInternal.propTypes = allProps;

src/components/Space.tsx

@@ -7,6 +7,10 @@ import { CommonHeader } from "../Utils";
 
 ## Change history
 
+### 0.1.29
+
+- Fixed overlayHandle property on resizable spaces which was broken in `0.1.25`
+
 ### 0.1.28
 
 - Ensure proptypes added as direct dependency to library