Skip to content

Improve language of XSJSAuthentication.md #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2025
Merged

Improve language of XSJSAuthentication.md #196

merged 2 commits into from
May 22, 2025

Conversation

@jeongsoolee09
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 commented May 19, 2025

What this PR contributes

  • Make the content of the file not specific to XSJS anymore by using a more general term "HANA XS application".
    • However, keep the @id of the query to match those of other XSJS queries.
  • Improve the flow of the language.

@jeongsoolee09 jeongsoolee09 requested a review from lcartey May 19, 2025 15:28
@jeongsoolee09 jeongsoolee09 merged commit 7ae1aa6 into main May 22, 2025
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the jeongsoolee09/XSJS-docs-update branch May 22, 2025 22:08
@jeongsoolee09 jeongsoolee09 restored the jeongsoolee09/XSJS-docs-update branch May 27, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lcartey lcartey lcartey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeongsoolee09 @lcartey