Demote LogArgumentToListener to a query-dependent flow step

Author: jeongsoolee09

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5LogsToHttpQuery.qll

@@ -30,11 +30,8 @@ module UI5LogEntryToHttp implements DataFlow::StateConfigSig {
     preState = postState
     or
     /*
-     * NOTE: This disjunct is a labeled version of LogArgumentToListener in
-     * FlowSteps.qll, a DataFlow::SharedFlowStep. As the class is considered
-     * legacy on version 2.4.0, we leave the two here (labeled) and there
-     * (unlabeled). This is something we should also tidy up when we migrate
-     * to the newer APIs.
+     * Jump from any argument of a SAP logging function to the `onLogEntry`
+     * method of a custom log listener in the same application.
      */
 
     inSameWebApp(start.getFile(), end.getFile()) and

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/dataflow/FlowSteps.qll

@@ -341,20 +341,4 @@ class ResourceBundleGetTextCallArgToReturnValueStep extends DataFlow::SharedFlow
       end = getTextCall
     )
   }
-}
-
-/**
- * A step from any argument of a SAP logging function to the `onLogEntry`
- * method of a custom log listener in the same application.
- */
-class LogArgumentToListener extends DataFlow::SharedFlowStep {
-  override predicate step(DataFlow::Node start, DataFlow::Node end) {
-    inSameWebApp(start.getFile(), end.getFile()) and
-    start =
-      ModelOutput::getATypeNode("SapLogger")
-          .getMember(["debug", "error", "fatal", "info", "trace", "warning"])
-          .getACall()
-          .getAnArgument() and
-    end = ModelOutput::getATypeNode("SapLogEntries").asSource()
-  }
-}
+}