Skip to content

Commit daec825

Browse files
committed
Remove LogArgumentToListener from FlowSteps.qll
This step involves `DataFlow::FlowLabel`s that is subjective to the query that is using this step. Therefore, remove it from the shared flow step, and put it only in the query or query library which define the labels to be propagated through this step.
1 parent 61b8ecc commit daec825

File tree

1 file changed

+0
-20
lines changed
  • javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/dataflow

1 file changed

+0
-20
lines changed

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/dataflow/FlowSteps.qll

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -342,23 +342,3 @@ class ResourceBundleGetTextCallArgToReturnValueStep extends DataFlow::SharedFlow
342342
)
343343
}
344344
}
345-
// /**
346-
// * A step from any argument of a SAP logging function to the `onLogEntry`
347-
// * method of a custom log listener in the same application.
348-
// */
349-
// class LogArgumentToListener extends DataFlow::SharedFlowStep {
350-
// deprecated override predicate step(
351-
// DataFlow::Node start, DataFlow::Node end, DataFlow::FlowLabel preLabel,
352-
// DataFlow::FlowLabel postLabel
353-
// ) {
354-
// inSameWebApp(start.getFile(), end.getFile()) and
355-
// start =
356-
// ModelOutput::getATypeNode("SapLogger")
357-
// .getMember(["debug", "error", "fatal", "info", "trace", "warning"])
358-
// .getACall()
359-
// .getAnArgument() and
360-
// end = ModelOutput::getATypeNode("SapLogEntries").asSource() and
361-
// preLabel = "logged" and
362-
// postLabel = "accessed"
363-
// }
364-
// }

0 commit comments

Comments
 (0)