Merge pull request #177 from advanced-security/lcartey/performance-improvements

Address a performance regression in recent upgrade

Author: lcartey

javascript/frameworks/cap/lib/advanced_security/javascript/frameworks/cap/CDL.qll

@@ -165,8 +165,8 @@ class CdlService extends CdlElement {
   CdlService() { kind = CdlServiceKind(this.getPropStringValue("kind")) }
 
   UserDefinedApplicationService getImplementation() {
-    this.getFile().getStem() = result.getFile().getStem() + ".cds" and
-    this.getFile().getParentContainer() = this.getFile().getParentContainer()
+    result.getFile().getRelativePath().regexpReplaceAll("\\.[^.]+$", ".cds.json") =
+      this.getFile().getRelativePath()
   }
 
   /**

javascript/frameworks/cap/lib/advanced_security/javascript/frameworks/cap/CDS.qll

@@ -442,13 +442,7 @@ abstract class UserDefinedApplicationService extends UserDefinedService {
   /**
    * Gets the CDS definition of this service.
    */
-  CdlService getCdsDeclaration() {
-    exists(CdsFile cdsFile |
-      cdsFile.getStem() = this.getFile().getStem() + ".cds" and
-      cdsFile.getParentContainer() = this.getFile().getParentContainer() and
-      result.getFile() = cdsFile
-    )
-  }
+  CdlService getCdsDeclaration() { result.getImplementation() = this }
 
   /**
    * Gets the name of this service.