Skip to content

Commit 761c638

Browse files
committed
Remove binding path cartesian product
`source` was not bound within MkConstBindingPathComponentList, and was semantically unused outside the class itself.
1 parent e715c35 commit 761c638

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/BindingStringParser.qll

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -839,18 +839,18 @@ module BindingStringParser<BindingStringReaderSig BindingStringReader> {
839839
then
840840
exists(BindingPathComponentList tail |
841841
mkBindingPathComponentList(getNextSkippingWhitespace(nextToken), tail, last) and
842-
list = MkConstBindingPathComponentList(name, tail, first)
842+
list = MkConstBindingPathComponentList(name, tail)
843843
)
844844
else (
845-
list = MkConstBindingPathComponentList(name, MkEmptyBindingPathComponentList(), first) and
845+
list = MkConstBindingPathComponentList(name, MkEmptyBindingPathComponentList()) and
846846
last = name
847847
)
848848
)
849849
}
850850

851851
private newtype TBindingPathComponentList =
852852
MkEmptyBindingPathComponentList() or
853-
MkConstBindingPathComponentList(NameToken headToken, BindingPathComponentList tail, Token source) {
853+
MkConstBindingPathComponentList(NameToken headToken, BindingPathComponentList tail) {
854854
exists(Token nextToken | nextToken = getNextSkippingWhitespace(headToken) |
855855
if nextToken instanceof ForwardSlashToken or nextToken instanceof DotToken
856856
then mkBindingPathComponentList(getNextSkippingWhitespace(nextToken), tail, _)
@@ -863,18 +863,16 @@ module BindingStringParser<BindingStringReaderSig BindingStringReader> {
863863
this = MkEmptyBindingPathComponentList() and result = ""
864864
or
865865
exists(NameToken head, BindingPathComponentList tail |
866-
this = MkConstBindingPathComponentList(head, tail, _) and
866+
this = MkConstBindingPathComponentList(head, tail) and
867867
if tail instanceof MkEmptyBindingPathComponentList
868868
then result = head.toString()
869869
else result = head.toString() + "/" + tail.toString()
870870
)
871871
}
872872

873-
NameToken getHead() { this = MkConstBindingPathComponentList(result, _, _) }
873+
NameToken getHead() { this = MkConstBindingPathComponentList(result, _) }
874874

875-
BindingPathComponentList getTail() { this = MkConstBindingPathComponentList(_, result, _) }
876-
877-
Token getSource() { this = MkConstBindingPathComponentList(_, _, result) }
875+
BindingPathComponentList getTail() { this = MkConstBindingPathComponentList(_, result) }
878876
}
879877

880878
predicate mkAbsoluteBindingPath(Token first, BindingPath path, Token last) {

0 commit comments

Comments
 (0)