Skip to content

Commit 4e9cdf0

Browse files
committed
Debutg JQueryDefineModule and CustomController.getAModelReference/0
1 parent 5bb503b commit 4e9cdf0

File tree

1 file changed

+6
-4
lines changed
  • javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5

1 file changed

+6
-4
lines changed

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ class JQuerySap extends DataFlow::SourceNode {
215215
*/
216216
class JQueryDefineModule extends UserModule, MethodCallExpr {
217217
JQueryDefineModule() {
218-
exists(JQuerySap jQuerySap | this = jQuerySap.getAMemberCall(["declare", "define"]).asExpr())
218+
exists(JQuerySap jQuerySap | this = jQuerySap.getAMemberCall(["declare", "require"]).asExpr())
219219
}
220220

221221
override string getADependency() { result = this.getArgument(0).getStringValue() }
@@ -496,11 +496,13 @@ class CustomController extends SapExtendCall {
496496
}
497497

498498
ModelReference getModelReference(string modelName) {
499-
result = this.getAViewReference().getAMemberCall("getModel") and
500-
result.getArgument(0).getALocalSource().getStringValue() = modelName
499+
result = this.getAModelReference() and
500+
result.getArgument(0).getALocalSource().asExpr().(StringLiteral).getValue() = modelName
501501
}
502502

503-
ModelReference getAModelReference() { result = this.getModelReference(_) }
503+
ModelReference getAModelReference() {
504+
result = this.getAViewReference().getAMemberCall("getModel")
505+
}
504506

505507
RouterReference getARouterReference() {
506508
exists(ThisNode controllerThis | controllerThis.getBinder() = this.getAMethod() |

0 commit comments

Comments
 (0)