Skip to content

Commit 2673f53

Browse files
committed
Document index-files change for grandfathered package.json
1 parent 0b6994c commit 2673f53

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

extractors/cds/tools/index-files.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,12 @@ try {
119119
* Nested package.json files simply cause the package to be installed in the parent
120120
* node_modules directory.
121121
*
122-
* TODO : fix implementation or change ^comment^ to reflect the actual implementation.
123-
*
124122
* We also ensure we skip node_modules, as we can end up in a recursive loop.
123+
*
124+
* NOTE: The original (sh-based) implementation of this extractor would also capture
125+
* "grandfathered" package.json files, which are package.json files that exist in a
126+
* parent directory of the first package.json file found. This (js-based) implementation
127+
* removes this behavior as it seems unnecessary and potentially problematic.
125128
*/
126129
responseFiles.forEach(file => {
127130
let dir = dirname(quote([file]));

0 commit comments

Comments
 (0)