Skip to content

Potential fix for code scanning alert no. 38: Missing rate limiting #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 38: Missing rate limiting #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"pdfkit": "^0.14.0",
"socket.io": "^4.7.2",
"stripe": "^14.4.0",
"uuid": "^11.1.0"
"uuid": "^11.1.0",
"express-rate-limit": "^7.5.0"
},
"devDependencies": {
"@types/debug": "^4.1.9",
Expand Down
12 changes: 11 additions & 1 deletion routes/GenericRoutes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const express = require("express");
const router = express.Router();
const rateLimit = require("express-rate-limit");

// ==========================
// Controllers
Expand All @@ -10,10 +11,19 @@ const {
createPaymentIntent,
} = require("../functions/CreatePaymentIntent.js");

// ==========================
// Rate Limiting
// ==========================
const loginRateLimiter = rateLimit({
windowMs: 15 * 60 * 1000, // 15 minutes
max: 100, // limit each IP to 100 requests per windowMs
message: "Too many login attempts from this IP, please try again later.",
});

// ==========================
// Routes
// ==========================
router.post("/login", LoginController.login);
router.post("/login", loginRateLimiter, LoginController.login);
router.post("/logout", LoginController.logout);
router.post("/resetPassword", resetPassword);
router.post("/payment/payment-intent", createPaymentIntent);
Expand Down