[1.x] Fix some compile time warnings with .NET 8/9 (kapi2289#20)

* fix some compile time warnings

* .net 8

* restore header keys

* added .net 9

* update version in actions

Author: adrum

.github/workflows/dotnet.yml

@@ -19,7 +19,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 6.0.x
+        dotnet-version: 9.0.x
     - name: Restore dependencies
       run: dotnet restore
     - name: Build

InertiaCore/Extensions/Configure.cs

@@ -69,7 +69,7 @@ private static async Task OnVersionChange(HttpContext context, IApplicationBuild
 
         if (tempData.Any()) tempData.Keep();
 
-        context.Response.Headers.Add("X-Inertia-Location", context.RequestedUri());
+        context.Response.Headers.Override("X-Inertia-Location", context.RequestedUri());
         context.Response.StatusCode = (int)HttpStatusCode.Conflict;
 
         await context.Response.CompleteAsync();

InertiaCore/Extensions/InertiaExtensions.cs

@@ -31,4 +31,16 @@ internal static bool IsInertiaRequest(this HttpContext context) =>
     internal static bool IsInertiaRequest(this ActionContext context) => context.HttpContext.IsInertiaRequest();
 
     internal static string ToCamelCase(this string s) => JsonNamingPolicy.CamelCase.ConvertName(s);
+
+    internal static bool Override<TKey, TValue>(this IDictionary<TKey, TValue> dictionary, TKey key, TValue value)
+    {
+        if (dictionary.ContainsKey(key))
+        {
+            dictionary[key] = value;
+            return true;
+        }
+
+        dictionary.Add(key, value);
+        return false;
+    }
 }

InertiaCore/InertiaCore.csproj

@@ -3,7 +3,7 @@
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <Version>0.0.9</Version>
-        <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+        <TargetFrameworks>net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
         <PackageId>AspNetCore.InertiaCore</PackageId>
         <Authors>kapi2289</Authors>
         <Description>Inertia.js ASP.NET Adapter. https://inertiajs.com/</Description>

InertiaCore/Response.cs

@@ -81,8 +81,8 @@ protected internal void ProcessResponse()
 
     protected internal JsonResult GetJson()
     {
-        _context!.HttpContext.Response.Headers.Add("X-Inertia", "true");
-        _context!.HttpContext.Response.Headers.Add("Vary", "Accept");
+        _context!.HttpContext.Response.Headers.Override("X-Inertia", "true");
+        _context!.HttpContext.Response.Headers.Override("Vary", "Accept");
         _context!.HttpContext.Response.StatusCode = 200;
 
         return new JsonResult(_page, new JsonSerializerOptions

InertiaCore/Utils/InertiaActionFilter.cs

@@ -32,7 +32,7 @@ public void OnActionExecuted(ActionExecutedContext context)
         };
 
         if (destinationUrl == null) return;
-        context.HttpContext.Response.Headers.Add("Location", destinationUrl);
+        context.HttpContext.Response.Headers.Override("Location", destinationUrl);
         context.Result = new StatusCodeResult((int)HttpStatusCode.RedirectMethod);
     }
 

InertiaCore/Utils/LocationResult.cs

@@ -14,7 +14,7 @@ public async Task ExecuteResultAsync(ActionContext context)
     {
         if (context.IsInertiaRequest())
         {
-            context.HttpContext.Response.Headers.Add("X-Inertia-Location", _url);
+            context.HttpContext.Response.Headers.Override("X-Inertia-Location", _url);
             await new StatusCodeResult((int)HttpStatusCode.Conflict).ExecuteResultAsync(context);
             return;
         }

InertiaCoreTests/InertiaCoreTests.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+        <TargetFrameworks>net6.0;net7.0;net8.0;net9.0</TargetFrameworks>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>