-
Notifications
You must be signed in to change notification settings - Fork 206
feat(backgroundlayers): class based implementation [CSS-1268] #2368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backgroundlayers): class based implementation [CSS-1268] #2368
Conversation
61a87a1 to
c9dadf3
Compare
d2ac17c to
b2fee42
Compare
31afc05 to
909f232
Compare
9a01c5a to
1b959b3
Compare
98335ab to
fec70b3
Compare
7c86724 to
0a218bc
Compare
0f20c5b to
9ff2a2c
Compare
4d9e185 to
a81c712
Compare
e03868f to
b3b3aa5
Compare
f3dd9ff to
9931a8e
Compare
905c91b to
8f768fd
Compare
8a0bac8 to
8cdffb5
Compare
|
6922285 to
feb718e
Compare
📚 Branch previewPR #2368 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-2368/index.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
Expected indentation of 1 tab but found 2 spaces.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'id' is defined but never used.
Expected indentation of 1 tab but found 2 spaces.
| customClasses = [], |
Expected indentation of 1 tab but found 2 spaces.
| return html` |
components/backgroundlayers/stories/backgroundlayers.stories.js
Outdated
Show resolved
Hide resolved
components/backgroundlayers/stories/backgroundlayers.stories.js
Outdated
Show resolved
Hide resolved
components/backgroundlayers/stories/backgroundlayers.stories.js
Outdated
Show resolved
Hide resolved
components/backgroundlayers/stories/backgroundlayers.stories.js
Outdated
Show resolved
Hide resolved
components/backgroundlayers/stories/backgroundlayers.stories.js
Outdated
Show resolved
Hide resolved
File metricsSummaryTotal size: 1.43 MB* 🎉 No changes detected in any packages * Size is the sum of all main files for packages in the library.* An ASCII character in UTF-8 is 8 bits or 1 byte. |
efc91bf to
b6ab87c
Compare
f8a4d6a to
fe382f3
Compare
fe382f3 to
7c8f1b8
Compare
Description
Creates utility classes which can be used by adding background layers to the dependencies for the component and then using the classes where needed.
Changes:
View Comments from previous branch for background layers that is now closed: #2274
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list