Skip to content

Conversation

@jenndiaz
Copy link
Contributor

@jenndiaz jenndiaz commented Dec 13, 2023

Description

Creates utility classes which can be used by adding background layers to the dependencies for the component and then using the classes where needed.

Changes:

  • Created a utility like "component" for background layers. This should eventually live in it's own section of the docs site. I didn't focus too much on navigation for the docs site or editing the nav.pug file.
  • index.css has classes for each of the layers specified in the specs for background layers which can be used directly
  • class names intentionally include the context it should be used in, editting vs browsing
  • In storybook background layers is in it's own section "utility classes"

View Comments from previous branch for background layers that is now closed: #2274

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@jenndiaz jenndiaz force-pushed the background-layers-class-based-approach branch from 61a87a1 to c9dadf3 Compare January 10, 2024 18:58
@pfulton pfulton force-pushed the spectrum-two branch 2 times, most recently from d2ac17c to b2fee42 Compare January 11, 2024 14:31
@pfulton pfulton force-pushed the spectrum-two branch 4 times, most recently from 31afc05 to 909f232 Compare January 22, 2024 20:15
@pfulton pfulton force-pushed the spectrum-two branch 3 times, most recently from 9a01c5a to 1b959b3 Compare February 5, 2024 21:12
@pfulton pfulton force-pushed the spectrum-two branch 2 times, most recently from 98335ab to fec70b3 Compare February 26, 2024 19:47
@pfulton pfulton force-pushed the spectrum-two branch 2 times, most recently from 7c86724 to 0a218bc Compare March 28, 2024 14:22
@castastrophe castastrophe force-pushed the spectrum-two branch 5 times, most recently from 0f20c5b to 9ff2a2c Compare April 5, 2024 14:36
@pfulton pfulton force-pushed the spectrum-two branch 2 times, most recently from e03868f to b3b3aa5 Compare April 15, 2024 19:32
@pfulton pfulton force-pushed the spectrum-two branch 2 times, most recently from f3dd9ff to 9931a8e Compare April 19, 2024 18:22
@castastrophe castastrophe force-pushed the spectrum-two branch 3 times, most recently from 905c91b to 8f768fd Compare April 26, 2024 16:34
@castastrophe castastrophe force-pushed the background-layers-class-based-approach branch 2 times, most recently from 8a0bac8 to 8cdffb5 Compare August 25, 2025 13:08
@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2025

⚠️ No Changeset found

Latest commit: 7c8f1b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe force-pushed the background-layers-class-based-approach branch 3 times, most recently from 6922285 to feb718e Compare August 25, 2025 13:14
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2025

📚 Branch preview

PR #2368 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-2368/index.html.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 1 tab but found 2 spaces.


🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'id' is defined but never used.


⚠️ [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 1 tab but found 2 spaces.


⚠️ [eslint] <indent> reported by reviewdog 🐶
Expected indentation of 1 tab but found 2 spaces.

@castastrophe castastrophe changed the title feat(backgroundlayers): class based implementation feat(backgroundlayers): class based implementation [CSS-1268] Aug 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2025

File metrics

Summary

Total size: 1.43 MB*

🎉 No changes detected in any packages

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe force-pushed the background-layers-class-based-approach branch 7 times, most recently from efc91bf to b6ab87c Compare August 25, 2025 15:14
@castastrophe castastrophe force-pushed the background-layers-class-based-approach branch from f8a4d6a to fe382f3 Compare October 22, 2025 14:48
@castastrophe castastrophe marked this pull request as ready for review October 22, 2025 14:49
@castastrophe castastrophe enabled auto-merge (squash) October 22, 2025 14:49
@castastrophe castastrophe force-pushed the background-layers-class-based-approach branch from fe382f3 to 7c8f1b8 Compare October 22, 2025 14:51
@castastrophe castastrophe disabled auto-merge October 22, 2025 14:51
@castastrophe castastrophe enabled auto-merge (squash) October 22, 2025 14:51
@castastrophe castastrophe merged commit 95c430e into spectrum-two Oct 22, 2025
14 of 15 checks passed
@castastrophe castastrophe deleted the background-layers-class-based-approach branch October 22, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants