Skip to content

Commit f35a58e

Browse files
authored
fix(coachmark): correct invalid token pointers in pagination styles [CSS-1011] (#3292)
Update coach mark pagination to add `font-family`, using the existing custom property. Update the `font-weight` and `line-height` to reference the correct tokens.
1 parent db450d8 commit f35a58e

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

.changeset/lucky-experts-grow.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@spectrum-css/coachmark": minor
3+
---
4+
5+
Update coach mark pagination to add `font-family`, using the existing custom property. Update the `font-weight` and `line-height` to reference the correct tokens.

components/coachmark/index.css

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
--spectrum-coachmark-content-font-size: var(--spectrum-coach-mark-body-size);
4545

4646
--spectrum-coachmark-step-color: var(--spectrum-coach-mark-pagination-color);
47-
--spectrum-coachmark-step-font-weight: var(--spectrum-body-medium-font-weight);
47+
--spectrum-coachmark-step-font-weight: var(--spectrum-body-sans-serif-font-weight);
4848
--spectrum-coachmark-step-font-family: var(--spectrum-sans-serif-font);
4949
--spectrum-coachmark-step-font-style: var(--spectrum-body-sans-serif-font-style);
5050
--spectrum-coachmark-step-line-height: var(--spectrum-body-line-height);
@@ -57,9 +57,7 @@
5757
--mod-popover-corner-radius: var(--spectrum-corner-radius-100);
5858
--mod-popover-content-area-spacing-vertical: 0;
5959
--mod-button-edge-to-visual-only: 9px;
60-
}
6160

62-
.spectrum-CoachMark {
6361
position: relative;
6462
min-inline-size: var(--mod-coachmark-min-width, var(--spectrum-coachmark-min-width));
6563
max-inline-size: var(--mod-coachmark-max-width, var(--spectrum-coachmark-max-width));
@@ -158,9 +156,10 @@
158156
justify-self: start;
159157
color: var(--mod-coachmark-step-color, var(--spectrum-coachmark-step-color));
160158
font-size: var(--mod-coachmark-step-font-size, var(--spectrum-coachmark-step-font-size));
161-
font-weight: var(--mod-coachmark-step-text-font-weight, var(--spectrum-coachmark-step-text-font-weight));
159+
font-weight: var(--mod-coachmark-step-text-font-weight, var(--spectrum-coachmark-step-font-weight));
160+
font-family: var(--spectrum-coachmark-step-font-family);
162161
font-style: var(--mod-coachmark-step-font-style, var(--spectrum-coachmark-step-font-style));
163-
line-height: var(--mod-coachmark-step-text-line-height, var(--spectrum-coachmark-step-text-line-height));
162+
line-height: var(--mod-coachmark-step-text-line-height, var(--spectrum-coachmark-step-line-height));
164163
white-space: nowrap;
165164
margin-block-end: calc(var(--mod-coachmark-step-to-bottom, var(--spectrum-coachmark-step-to-bottom)) - var(--mod-coachmark-padding, var(--spectrum-coachmark-padding)));
166165
}

components/coachmark/metadata/metadata.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@
8585
"--spectrum-coachmark-step-font-style",
8686
"--spectrum-coachmark-step-font-weight",
8787
"--spectrum-coachmark-step-line-height",
88-
"--spectrum-coachmark-step-text-font-weight",
89-
"--spectrum-coachmark-step-text-line-height",
9088
"--spectrum-coachmark-step-to-bottom",
9189
"--spectrum-coachmark-title-color",
9290
"--spectrum-coachmark-title-font-family",
@@ -99,7 +97,6 @@
9997
"global": [
10098
"--spectrum-body-color",
10199
"--spectrum-body-line-height",
102-
"--spectrum-body-medium-font-weight",
103100
"--spectrum-body-sans-serif-font-style",
104101
"--spectrum-body-sans-serif-font-weight",
105102
"--spectrum-border-width-100",

0 commit comments

Comments
 (0)