-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add configuration management APIs #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR will trigger a minor release when merged. |
ramboz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks overall good to me
ravverma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tathagat2241 minor comments, please address
packages/spacecat-shared-data-access/src/models/configuration/configuration.model.js
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/models/configuration/configuration.model.js
Outdated
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/models/configuration/configuration.model.js
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/models/configuration/configuration.model.js
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/models/configuration/configuration.model.js
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/models/configuration/configuration.model.js
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/models/configuration/configuration.model.js
Outdated
Show resolved
Hide resolved
packages/spacecat-shared-data-access/src/models/configuration/configuration.model.js
Outdated
Show resolved
Hide resolved
# [@adobe/spacecat-shared-data-access-v2.86.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v2.85.1...@adobe/spacecat-shared-data-access-v2.86.0) (2025-11-19) ### Features * add configuration management APIs ([#1063](#1063)) ([d6988a9](d6988a9))
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v2.86.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
This PR adds new configuration management methods to support API-driven configuration updates
Changes Made
Configuration Model (
configuration.model.js)updateQueues(queues)- Update queue configurationsupdateJob(type, properties)- Update job properties (interval, group)updateHandlerProperties(type, properties)- Update handler settings (enabledByDefault, productCodes, dependencies, thresholds)updateConfiguration(data)- Flexible method to update multiple configuration sections at onceproductCodesa required and non-empty field for handlersrestore(version)- restores the last good versionregister(audit)andunregister(audit)- remove AUDIT_TYPES static list validation.Configuration Schema (
configuration.schema.js)productCodeswith minimum 1 itemConfiguration Index (
index.js)checkConfigurationfunction for response validationTesting
Please ensure your pull request adheres to the following guidelines:
Related Issues
https://jira.corp.adobe.com/browse/LLMO-908
Thanks for contributing!