Skip to content

Conversation

@tathagat2241
Copy link
Contributor

@tathagat2241 tathagat2241 commented Oct 29, 2025

Summary

This PR adds new configuration management methods to support API-driven configuration updates

Changes Made

Configuration Model (configuration.model.js)

  • Added updateQueues(queues) - Update queue configurations
  • Added updateJob(type, properties) - Update job properties (interval, group)
  • Added updateHandlerProperties(type, properties) - Update handler settings (enabledByDefault, productCodes, dependencies, thresholds)
  • Added updateConfiguration(data) - Flexible method to update multiple configuration sections at once
  • Made productCodes a required and non-empty field for handlers
  • Added restore(version) - restores the last good version
  • Enhanced register(audit) and unregister(audit) - remove AUDIT_TYPES static list validation.

Configuration Schema (configuration.schema.js)

  • Updated handler schema to require productCodes with minimum 1 item

Configuration Index (index.js)

  • Exported checkConfiguration function for response validation

Testing

  • All tests passing (1133 tests)

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

https://jira.corp.adobe.com/browse/LLMO-908

Thanks for contributing!

@github-actions
Copy link

This PR will trigger a minor release when merged.

Copy link

@ramboz ramboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good to me

Copy link
Contributor

@ravverma ravverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tathagat2241 minor comments, please address

@tathagat2241 tathagat2241 merged commit d6988a9 into main Nov 19, 2025
8 of 9 checks passed
@tathagat2241 tathagat2241 deleted the global-config-api branch November 19, 2025 06:36
solaris007 pushed a commit that referenced this pull request Nov 19, 2025
@solaris007
Copy link
Member

🎉 This PR is included in version @adobe/spacecat-shared-data-access-v2.86.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants