Cap overlay max height to 100vh on initial render (#6525)

devongovett · web-flow · commit 91f63a6519e1 · 2024-06-11T19:57:52.000-07:00
diff --git a/packages/@react-aria/overlays/src/useOverlayPosition.ts b/packages/@react-aria/overlays/src/useOverlayPosition.ts
@@ -250,7 +250,7 @@ export function useOverlayPosition(props: AriaPositionProps): PositionAria {
         position: 'absolute',
         zIndex: 100000, // should match the z-index in ModalTrigger
         ...position.position,
-        maxHeight: position.maxHeight
+        maxHeight: position.maxHeight ?? '100vh'
       }
     },
     placement: position.placement,

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ export function useOverlayPosition(props: AriaPositionProps): PositionAria {`
`250`	`250`	`position: 'absolute',`
`251`	`251`	`zIndex: 100000, // should match the z-index in ModalTrigger`
`252`	`252`	`...position.position,`
`253`		`- maxHeight: position.maxHeight`
	`253`	`+ maxHeight: position.maxHeight ?? '100vh'`
`254`	`254`	`}`
`255`	`255`	`},`
`256`	`256`	`placement: position.placement,`