Skip to content

Commit 5a45466

Browse files
committed
Merge branch 'main' into update-eslint-plugin-react-hooks
# Conflicts: # yarn.lock
2 parents 30bc1fa + 59a2b92 commit 5a45466

File tree

71 files changed

+692
-2882
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+692
-2882
lines changed

.circleci/config.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -816,9 +816,10 @@ jobs:
816816
- run:
817817
name: deploy
818818
command: |
819-
azcopy copy "/tmp/dist/production/docs/*" "https://reactspectrum.blob.core.windows.net/\$web${AZURE_STORAGE_SAS_TOKEN}" --recursive --exclude-pattern "*.md;*.txt"
820-
azcopy copy "/tmp/dist/production/docs/*" "https://reactspectrum.blob.core.windows.net/\$web${AZURE_STORAGE_SAS_TOKEN}" --recursive --include-pattern "*.md" --content-type "text/markdown; charset=utf-8"
821-
azcopy copy "/tmp/dist/production/docs/*" "https://reactspectrum.blob.core.windows.net/\$web${AZURE_STORAGE_SAS_TOKEN}" --recursive --include-pattern "*.txt" --content-type "text/plain; charset=utf-8"
819+
azcopy copy "/tmp/dist/production/docs/*" "https://reactspectrum.blob.core.windows.net/\$web${AZURE_STORAGE_SAS_TOKEN}" --recursive --exclude-pattern "*.md;*.txt;*.html;*.rsc"
820+
azcopy copy "/tmp/dist/production/docs/*" "https://reactspectrum.blob.core.windows.net/\$web${AZURE_STORAGE_SAS_TOKEN}" --recursive --include-pattern "*.md" --content-type "text/markdown; charset=utf-8" --cache-control "max-age=300"
821+
azcopy copy "/tmp/dist/production/docs/*" "https://reactspectrum.blob.core.windows.net/\$web${AZURE_STORAGE_SAS_TOKEN}" --recursive --include-pattern "*.txt" --content-type "text/plain; charset=utf-8" --cache-control "max-age=300"
822+
azcopy copy "/tmp/dist/production/docs/*" "https://reactspectrum.blob.core.windows.net/\$web${AZURE_STORAGE_SAS_TOKEN}" --recursive --include-pattern "*.html;*.rsc" --cache-control "max-age=300"
822823
823824
comment:
824825
executor: rsp

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
.DS_Store
22
.cache
33
.idea
4-
.nyc_output
54
.package-lock.json
65
.parcel-cache
76
build-storybook.log

.npmignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
.DS_Store
22
.storybook
33
.editorconfig
4-
.nycrc
5-
.nyc_output
64
coverage
75
Makefile
86
yarn.lock

.nycrc

Lines changed: 0 additions & 8 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -77,32 +77,6 @@ Or run the documentation and browse to [http://localhost:1234/](http://localhost
7777
yarn start:docs
7878
```
7979

80-
### Component/Hook scaffolding
81-
If you are looking to contribute a brand new component or Hook in a package that does not exist yet, please run the following command.
82-
```bash
83-
yarn plop
84-
```
85-
This will start a series of cli prompts to determine what template files and folders should be generated to help quick start your contribution.
86-
The prompts are as follows:
87-
88-
1. What type of project are you setting up?
89-
- Select "React Spectrum v3"
90-
91-
2. Scope name(s)
92-
- Select the package scopes that make sense for your contribution (e.g. react-spectrum if you are contributing a component, react-aria for an aria Hook, etc)
93-
94-
3. Package name, all lowercase (e.g. textfield)
95-
96-
4. Component name, please use appropriate uppercase (e.g. TextField)
97-
- If you are contributing a non-component Hook, just enter the name of your Hook.
98-
99-
5. Component css module name, blank if N/A. If unsure, check @adobe/spectrum-css-temp/components for a module containing the desired css (e.g. textfield)
100-
- If you cannot find the component CSS module name in @adobe/spectrum-css-temp/components, feel free to reach out to a team member via GitHub Issues or Discussions.
101-
102-
Upon answering all the prompts, the appropriate package(s) should be generated and ready for modification.
103-
104-
**Note:** With regards to the generated docs files, please feel free to remove them if you won't be contributing docs. If you are contributing docs for a new component or Hook, please submit them in a separate pull request so that we can decide when to deploy them to our docs site.
105-
10680
### Tests
10781
We use [jest](https://jestjs.io/) for unit tests and [react-testing-library](https://testing-library.com/docs/react-testing-library/intro) for rendering and writing assertions. Please make sure you include tests with your pull requests. Our CI will run the tests on PRs as well as the linter and type checker. You can see on each PR whether you have passed all our checks. We split the tests into 2 groups.
10882

@@ -154,7 +128,7 @@ yarn start:docs
154128
Then, open [http://localhost:1234](http://localhost:1234) in your browser.
155129

156130
### Verdaccio
157-
We use [Verdaccio](https://verdaccio.org/) to set up a private registry for our packages to test our components in our example apps.
131+
We use [Verdaccio](https://verdaccio.org/) to set up a private registry for our packages to test our components in our example apps.
158132

159133
To run verdaccio, first ensure that your `git status` is clean. If your computer has an Intel chip, add the line `shopt -s globstar extglob` in the `verdaccio.sh` file after line 21. Save and commit these changes under a clear message like "Do not push". If you have an Apple silicon chip, you may skip this step.
160134

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,16 +146,16 @@ s2-api-diff:
146146
node scripts/api-diff.js --skip-same --skip-style-props
147147

148148
s2-docs:
149-
BASE_URL=https://reactspectrum.blob.core.windows.net PUBLIC_URL=/reactspectrum/$$(git rev-parse HEAD)/s2-docs DIST_DIR=dist/$$(git rev-parse HEAD)/s2-docs $(MAKE) build-s2-docs
149+
PUBLIC_URL=https://reactspectrum.blob.core.windows.net/reactspectrum/$$(git rev-parse HEAD)/s2-docs DIST_DIR=dist/$$(git rev-parse HEAD)/s2-docs $(MAKE) build-s2-docs
150150

151151
s2-docs-production:
152-
BASE_URL=https://react-spectrum.adobe.com PUBLIC_URL=/beta DIST_DIR=dist/production/docs/beta $(MAKE) build-s2-docs
152+
PUBLIC_URL=https://react-spectrum.adobe.com/beta DIST_DIR=dist/production/docs/beta $(MAKE) build-s2-docs
153153

154154
build-s2-docs:
155155
yarn workspace @react-spectrum/s2-docs generate:md
156156
yarn workspace @react-spectrum/s2-docs generate:og
157-
REGISTRY_URL=$(BASE_URL)$(PUBLIC_URL)/registry node scripts/buildRegistry.mjs
158-
REGISTRY_URL=$(BASE_URL)$(PUBLIC_URL)/registry yarn build:s2-docs --public-url $(PUBLIC_URL)
157+
REGISTRY_URL=$(PUBLIC_URL)/registry node scripts/buildRegistry.mjs
158+
REGISTRY_URL=$(PUBLIC_URL)/registry yarn build:s2-docs --public-url $(PUBLIC_URL)
159159
mkdir -p $(DIST_DIR)
160160
mv packages/dev/s2-docs/dist/* $(DIST_DIR)
161161
mkdir -p $(DIST_DIR)/registry

babel-esm.config.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@
2323
]
2424
]
2525
},
26-
"cover": {
27-
"plugins": [
28-
"istanbul"
29-
]
30-
},
3126
"production": {
3227
"plugins": [
3328
[

babel.config.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@
2222
]
2323
]
2424
},
25-
"cover": {
26-
"plugins": [
27-
"istanbul"
28-
]
29-
},
3025
"production": {
3126
"plugins": [
3227
[

package.json

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
"build:icons": "babel-node --presets @babel/env ./scripts/buildIcons.js",
4545
"clean:icons": "babel-node --presets @babel/env ./scripts/cleanIcons.js",
4646
"postinstall": "patch-package && yarn build:icons",
47-
"plop": "plop --plopfile scripts/plopfile.js",
4847
"chromatic": "NODE_ENV=production CHROMATIC=1 chromatic --project-token $CHROMATIC_PROJECT_TOKEN --build-script-name 'build:chromatic'",
4948
"chromatic:forced-colors": "NODE_ENV=production CHROMATIC=1 chromatic --project-token $CHROMATIC_FC_PROJECT_TOKEN --build-script-name 'build:chromatic-fc'",
5049
"merge:css": "babel-node --presets @babel/env ./scripts/merge-spectrum-css.js",
@@ -139,11 +138,9 @@
139138
"autoprefixer": "^9.6.0",
140139
"axe-core": "^4.6.3",
141140
"axe-playwright": "^1.1.11",
142-
"babel-plugin-istanbul": "^6.0.0",
143141
"babel-plugin-macros": "^3.0.1",
144142
"babel-plugin-react-remove-properties": "^0.3.0",
145143
"babel-plugin-transform-glob-import": "^1.0.1",
146-
"babelify": "^10.0.0",
147144
"chalk": "^4.1.2",
148145
"chromatic": "^13.1.3",
149146
"clsx": "^2.0.0",
@@ -165,8 +162,7 @@
165162
"fast-check": "^2.19.0",
166163
"fast-glob": "^3.1.0",
167164
"fs-extra": "^11.0.0",
168-
"glob": "^8.0.3",
169-
"glob-promise": "^6.0.5",
165+
"glob": "^11.0.3",
170166
"globals": "^15.11.0",
171167
"identity-obj-proxy": "^3.0.0",
172168
"ignore-styles": "^5.0.1",
@@ -181,30 +177,25 @@
181177
"md5": "^2.2.1",
182178
"motion": "^12.23.6",
183179
"npm-cli-login": "^1.0.0",
184-
"nyc": "^10.2.0",
185-
"p-queue": "^6.2.1",
186180
"parcel": "^2.16.0",
187181
"parcel-optimizer-strict-mode": "workspace:^",
188182
"patch-package": "^6.2.0",
189183
"playwright": "^1.45.3",
190-
"plop": "^2.4.0",
191184
"postcss": "^8.4.24",
192185
"postcss-custom-properties": "^13.2.0",
193186
"postcss-import": "^15.1.0",
194187
"prettier": "^3.6.2",
195188
"prop-types": "^15.6.0",
196189
"raf": "^3.4.0",
197190
"react": "^19.1.0",
198-
"react-axe": "^3.0.2",
199191
"react-dom": "^19.1.0",
200192
"react-frame-component": "^5.0.0",
201193
"react-test-renderer": "^19.1.0",
202194
"recast": "^0.23",
203195
"recursive-readdir": "^2.2.2",
204196
"regenerator-runtime": "0.13.3",
205-
"rimraf": "^2.6.3",
197+
"rimraf": "^6.0.1",
206198
"sharp": "^0.33.5",
207-
"sinon": "^7.3.1",
208199
"storybook": "^8.6.14",
209200
"storybook-dark-mode": "^4.0.2",
210201
"storybook-react-parcel": "workspace:^",
@@ -217,8 +208,7 @@
217208
"verdaccio": "^6.0.0",
218209
"walk-object": "^4.0.0",
219210
"wsrun": "^5.0.0",
220-
"xml": "^1.0.1",
221-
"yargs": "^17.2.1"
211+
"xml": "^1.0.1"
222212
},
223213
"resolutions": {
224214
"@babel/cli": "7.24.1",
@@ -229,7 +219,7 @@
229219
"@babel/traverse": "7.24.1",
230220
"@babel/types": "7.24.0",
231221
"@mdx-js/react": "2.0.0-rc.2",
232-
"postcss": "8.4.24",
222+
"postcss": "8.4.31",
233223
"postcss-custom-properties": "13.2.0",
234224
"postcss-import": "15.1.0",
235225
"react-refresh": "0.9.0",

0 commit comments

Comments
 (0)