Fixing enter keydown event on forms (#1653)

* link fix

* Link fix

* Fixing issue

Author: rismehta

ui.frontend/src/view/FormContainer.js

@@ -41,15 +41,25 @@ class FormContainer {
     }
 
     /**
-     * Prevents the default behavior of the Enter key on components within the formContainer
+     * Prevents the default behavior of the Enter key on text input components within the formContainer
      * from triggering a form submission and redirecting to the Thank-You Page.
+     * Preserves accessibility by allowing Enter key to work normally on interactive elements.
      */
     #preventDefaultSubmit(){
         if(this._element) {
             this._element.addEventListener('keydown', (event) => {
+                if (event.key !== 'Enter') {
+                    return;
+                }
+
                 const target = event.target;
-                const isSubmitOrReset = target.tagName === 'INPUT' && (target.type === 'submit' || target.type === 'reset');
-                if (event.key === 'Enter' && target.tagName !== 'SELECT' && target.tagName !== 'BUTTON' && !isSubmitOrReset) {
+                
+                // Only prevent default on text-like inputs that would cause unwanted form submission
+                // Allow Enter to work normally on buttons, links, elements with roles, and other interactive elements
+                const shouldPreventSubmission = target.tagName === 'INPUT' && 
+                    ['text', 'password', 'email', 'url', 'search', 'tel', 'number'].includes(target.type);
+                    
+                if (shouldPreventSubmission) {
                     event.preventDefault();
                 }
             });

ui.tests/test-module/specs/formcontainer.cy.js

@@ -385,5 +385,36 @@ describe('Page/Form Authoring', function () {
                     cy.get('.cmp-adaptiveform-numberinput__widget').eq(0).should('be.visible');
                 });
             });
+
+            it('should not prevent default behavior on links with enter key press', function () {
+                cy.get('.cmp-adaptiveform-container').then((formContainer) => {
+                    // Create a test link dynamically within the form container
+                    const testLink = document.createElement('a');
+                    testLink.href = '#test-link';
+                    testLink.textContent = 'Test Link';
+                    testLink.id = 'test-accessibility-link';
+                    testLink.setAttribute('tabindex', '0');
+                    formContainer[0].appendChild(testLink);
+
+                    // Test that Enter keydown event on link is NOT prevented by FormContainer
+                    cy.get('#test-accessibility-link').focus().then(($link) => {
+                        const linkElement = $link[0];
+                        
+                        // Create and dispatch a keydown event
+                        const enterKeyEvent = new KeyboardEvent('keydown', {
+                            key: 'Enter',
+                            code: 'Enter',
+                            bubbles: true,
+                            cancelable: true
+                        });
+                        
+                        // Dispatch the event and check if preventDefault was called
+                        const result = linkElement.dispatchEvent(enterKeyEvent);
+                        
+                        // If result is true, preventDefault was NOT called (which is what we want for links)
+                        expect(result).to.be.true;
+                    });
+                });
+            });
         });
 });