FORMS-16007 : rest endpoint url validation, to not allow relative url (#1505)

* restendpoint url validation

* cypress test and incorporating the review comments

* updating the fieldDescription

* removing the updatefieldDescription logic

---------

Co-authored-by: Shrikha . <smahanty@shrikhas-mbp.corp.adobe.com>
Co-authored-by: Shrikha . <smahanty@Shrikhas-MacBook-Pro.local>

Author: 3 people

ui.af.apps/src/main/content/jcr_root/apps/core/fd/components/form/container/v1/container/clientlibs/editor/js/editDialog.js

@@ -378,15 +378,18 @@
             if(restEndPointSource.length == 0 || isPostUrlSelected){
                 Utils.showComponent(restEndPointUrlTextBox, 'div');
                 Utils.hideComponent(restEndpointConfigPath, 'div');
+                restEndPointUrlTextBox?.setAttribute("data-rest-endpoint-url-validation", "");
             } else {
                 Utils.showComponent(restEndpointConfigPath, 'div');
                 Utils.hideComponent(restEndPointUrlTextBox, 'div');
+                restEndPointUrlTextBox?.removeAttribute("data-rest-endpoint-url-validation");
             }
         } else {
             Utils.hideComponent(restEndPointSource, 'div');
             Utils.hideComponent(restEndPointUrlTextBox, 'div');
             Utils.hideComponent(restEndpointConfigPath, 'div');
             restEndPointSource.parent('div').parent('div').hide();
+            restEndPointUrlTextBox?.removeAttribute("data-rest-endpoint-url-validation");
         }
     }
 
@@ -421,6 +424,7 @@
             $(document).off('change' + REST_ENDPOINT).on('change' + REST_ENDPOINT, restCheckBox, function(){
                 showPostUrlTextField(dialog);
             });
+            registerRestEndpointUrlValidator();
         }
     }
 
@@ -489,6 +493,22 @@
         }
     });
 
+    function registerRestEndpointUrlValidator() {
+        $(window).adaptTo("foundation-registry").register("foundation.validation.validator", {
+            selector: "[data-rest-endpoint-url-validation]",
+            validate: (el) => {
+                const url = el.value;
+                // Regex to validate absolute URLs starting with http:// or https:// only
+                const absoluteUrlPattern = /^https?:\/\/.+$/i;
+                if (!absoluteUrlPattern.test(url)) {
+                    return Granite.I18n.getMessage(
+                       "Please enter the absolute path of the REST endpoint."
+                    );
+                }
+            }
+        });
+    }
+
     Utils.initializeEditDialog(EDIT_DIALOG_FORM)(handleAsyncSubmissionAndThankYouOption, handleSubmitAction,
         registerSubmitActionSubDialogClientLibs, registerRestEndPointDialogClientlibs, registerFDMDialogClientlibs, registerEmailDialogClientlibs, initialiseDataModel, registerAutoSaveDialogAction);
 

ui.tests/test-module/specs/formcontainer.cy.js

@@ -76,7 +76,18 @@ describe('Page/Form Authoring', function () {
         cy.get("coral-numberinput[name='./fd:autoSaveInterval']").should("exist");
     }
 
-
+    const checkValidatorFunctioning = function(formContainerEditPathSelector) {
+        cy.openEditableToolbar(sitesSelectors.overlays.overlay.component + formContainerEditPathSelector);
+        cy.invokeEditableAction("[data-action='CONFIGURE']");
+        cy.get('.cmp-adaptiveform-container__editdialog').contains('Submission').click({force:true});   
+        cy.get(".cmp-adaptiveform-container__submitaction").children('button[is="coral-button"][aria-haspopup="listbox"]').first().click({force: true});
+        cy.get('coral-selectlist-item[value="fd/af/components/guidesubmittype/restendpoint"]').should('be.visible').click();
+        cy.get("[name='./restEndpointPostUrl']").scrollIntoView().clear({force: true}).type("invalid-url", {force: true});
+        cy.get('.coral-Form-errorlabel').should('contain.text', "Please enter the absolute path of the REST endpoint.");
+        cy.get("[name='./restEndpointPostUrl']").clear({force: true}).type("http://localhost:4502/some/endpoint", {force: true}); 
+        cy.get('.coral-Form-errorlabel').should('not.exist');
+        cy.get('.cq-dialog-submit').click();
+    };
 
     const checkAndSaveSubmitAction = function(formContainerEditPathSelector) {
         // click configure action on adaptive form container component
@@ -107,11 +118,11 @@ describe('Page/Form Authoring', function () {
             cy.get("[name='./restEndpointConfigPath']").should("exist").should("be.visible");
             cy.get("coral-radio[name='./restEndPointSource'][value='posturl']").first().click();
             cy.get("[name='./restEndpointPostUrl']").should("exist").should("be.visible");
+            cy.get("[name='./restEndpointPostUrl']").should("exist").clear().type("http://localhost:4502/some/endpoint");
             cy.get("[name='./restEndpointConfigPath']").should("exist").should("not.be.visible");
         }
-        cy.get("[name='./restEndpointPostUrl']").should("exist").type("http://localhost:4502/some/endpoint");
-
         //save the configuration
+        cy.get("[name='./restEndpointPostUrl']").scrollIntoView().should("exist").clear().type("http://localhost:4502/some/endpoint");
         cy.get('.cq-dialog-submit').click();
     };
 
@@ -243,6 +254,9 @@ describe('Page/Form Authoring', function () {
                 }
             });
 
+            it('check validator functioning for REST endpoint URL', function() {
+                checkValidatorFunctioning(formContainerEditPathSelector);
+            });
         });
 
         // commenting once we support adaptive form container in sites editor, uncomment this test
@@ -296,6 +310,10 @@ describe('Page/Form Authoring', function () {
                     checkEditDialog(formContainerEditPathSelector);
                     cy.get(sitesSelectors.confirmDialog.actions.first).click();
                 })
+
+                it('check validator functioning for REST endpoint URL', function() {
+                    checkValidatorFunctioning(formContainerEditPathSelector);
+                });
         });
 
         context("Render Forms in Disabled mode", function () {