Skip to content

Commit 902f0b9

Browse files
nonelseuerceg
authored andcommitted
Prevent possible non-string null fields in callbacks
1 parent 4fac087 commit 902f0b9

File tree

2 files changed

+24
-4
lines changed

2 files changed

+24
-4
lines changed

Adjust/adjust/src/main/java/com/adjust/sdk/EventResponseData.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.adjust.sdk;
22

3+
import org.json.JSONObject;
4+
35
/**
46
* Created by pfms on 09/02/16.
57
*/
@@ -19,7 +21,11 @@ public AdjustEventSuccess getSuccessResponseData() {
1921
successResponseData.message = message;
2022
successResponseData.timestamp = timestamp;
2123
successResponseData.adid = adid;
22-
successResponseData.jsonResponse = jsonResponse;
24+
if (jsonResponse != null) {
25+
successResponseData.jsonResponse = jsonResponse;
26+
} else {
27+
successResponseData.jsonResponse = new JSONObject();
28+
}
2329
successResponseData.eventToken = eventToken;
2430

2531
return successResponseData;
@@ -35,7 +41,11 @@ public AdjustEventFailure getFailureResponseData() {
3541
failureResponseData.timestamp = timestamp;
3642
failureResponseData.adid = adid;
3743
failureResponseData.willRetry = willRetry;
38-
failureResponseData.jsonResponse = jsonResponse;
44+
if (jsonResponse != null) {
45+
failureResponseData.jsonResponse = jsonResponse;
46+
} else {
47+
failureResponseData.jsonResponse = new JSONObject();
48+
}
3949
failureResponseData.eventToken = eventToken;
4050

4151
return failureResponseData;

Adjust/adjust/src/main/java/com/adjust/sdk/SessionResponseData.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package com.adjust.sdk;
22

3+
import org.json.JSONObject;
4+
35
/**
46
* Created by pfms on 09/02/16.
57
*/
@@ -13,7 +15,11 @@ public AdjustSessionSuccess getSuccessResponseData() {
1315
successResponseData.message = message;
1416
successResponseData.timestamp = timestamp;
1517
successResponseData.adid = adid;
16-
successResponseData.jsonResponse = jsonResponse;
18+
if (jsonResponse != null) {
19+
successResponseData.jsonResponse = jsonResponse;
20+
} else {
21+
successResponseData.jsonResponse = new JSONObject();
22+
}
1723

1824
return successResponseData;
1925
}
@@ -28,7 +34,11 @@ public AdjustSessionFailure getFailureResponseData() {
2834
failureResponseData.timestamp = timestamp;
2935
failureResponseData.adid = adid;
3036
failureResponseData.willRetry = willRetry;
31-
failureResponseData.jsonResponse = jsonResponse;
37+
if (jsonResponse != null) {
38+
failureResponseData.jsonResponse = jsonResponse;
39+
} else {
40+
failureResponseData.jsonResponse = new JSONObject();
41+
}
3242

3343
return failureResponseData;
3444
}

0 commit comments

Comments
 (0)