Remove neopixel_write workaround

Turns out it was a workaround for a bad LED on one particular board.

Author: gychang

ports/espressif/boards/espressif_esp32c3_lyra_v2/mpconfigboard.mk

@@ -8,7 +8,3 @@ CIRCUITPY_ESP_FLASH_FREQ = 80m
 CIRCUITPY_ESP_FLASH_SIZE = 4MB
 
 CIRCUITPY_ESP_USB_SERIAL_JTAG = 0
-
-ESPRESSIF_ESP32C3_LYRA_STATUS_LED_HOLD = 1
-
-CFLAGS += -DESPRESSIF_ESP32C3_LYRA_STATUS_LED_HOLD=$(ESPRESSIF_ESP32C3_LYRA_STATUS_LED_HOLD)

ports/espressif/common-hal/neopixel_write/__init__.c

@@ -126,21 +126,11 @@ void common_hal_neopixel_write(const digitalio_digitalinout_obj_t *digitalinout,
     // Update the next start to +2 ticks. It ensures that we've gone 300+ us.
     next_start_raw_ticks = port_get_raw_ticks(NULL) + 2;
 
-    #if defined(ESPRESSIF_ESP32C3_LYRA_STATUS_LED_HOLD)
-    // Hold the pin, deleting the channel seems to glitch pixels into turning off.
-    gpio_hold_en(digitalinout->pin->number);
-    #endif
-
     // Free channel again
     rmt_del_encoder(encoder);
     rmt_disable(channel);
     rmt_del_channel(channel);
     CHECK_ESP_RESULT(result);
     // Swap pin back to GPIO mode
     gpio_set_direction(digitalinout->pin->number, GPIO_MODE_OUTPUT);
-
-    #if defined(ESPRESSIF_ESP32C3_LYRA_STATUS_LED_HOLD)
-    // Release hold
-    gpio_hold_dis(digitalinout->pin->number);
-    #endif
 }