address @tyeth review

Author: brentru

src/Wippersnapper_V2.cpp

@@ -80,14 +80,14 @@ void Wippersnapper_V2::provision() {
 #ifdef USE_TINYUSB
   WsV2._fileSystemV2 = new Wippersnapper_FS();
 #elif defined(USE_LITTLEFS)
-  _littleFSV2 = new WipperSnapper_LittleFS();
+  WsV2._littleFSV2 = new WipperSnapper_LittleFS();
 #endif
 
 // Determine if app is in SDLogger mode
 #ifdef USE_TINYUSB
   WsV2._fileSystemV2->GetPinSDCS();
 #elif defined(USE_LITTLEFS)
-  _littleFSV2->GetPinSDCS();
+  WsV2._littleFSV2->GetPinSDCS();
 #elif defined(OFFLINE_MODE_WOKWI)
   WsV2.pin_sd_cs = 15;
 #endif
@@ -126,7 +126,7 @@ void Wippersnapper_V2::provision() {
 #ifdef USE_TINYUSB
   WsV2._fileSystemV2->ParseFileSecrets();
 #elif defined(USE_LITTLEFS)
-  _littleFSV2->ParseFileSecrets();
+  WsV2._littleFSV2->ParseFileSecrets();
 #else
   check_valid_ssid(); // non-fs-backed, sets global credentials within network
                       // iface

src/components/i2c/hardware.cpp

@@ -181,19 +181,19 @@ bool I2cHardware::ScanBus(wippersnapper_i2c_I2cBusScanned *scan_results) {
     // Check endTransmission()'s return code (Arduino-ESP32 ONLY)
     else if (endTransmissionRC == 3) {
       WS_DEBUG_PRINTLN("[i2c] Did not find device: NACK on transmit of data!");
-      return false;
+      continue;
     } else if (endTransmissionRC == 2) {
       // WS_DEBUG_PRINTLN("[i2c] Did not find device: NACK on transmit of
       // address!");
       continue;
     } else if (endTransmissionRC == 1) {
       WS_DEBUG_PRINTLN(
           "[i2c] Did not find device: data too long to fit in xmit buffer!");
-      return false;
+      continue;
     } else if (endTransmissionRC == 4) {
       WS_DEBUG_PRINTLN(
           "[i2c] Did not find device: Unspecified bus error occured!");
-      return false;
+      continue;
     } else if (endTransmissionRC == 5) {
       WS_DEBUG_PRINTLN("[i2c] Did not find device: Bus timed out!");
       continue;

src/provisioning/sdcard/ws_sdcard.cpp

@@ -59,8 +59,8 @@ ws_sdcard::ws_sdcard() {
     did_init = InitSdCard(WsV2.pin_sd_cs);
   }
 
-  // Case 2: Try to initialize the SD card with the default pin (within
-  // ws_adapters.h)
+  // Case 2: Try to initialize the SD card with the default
+  // board SD CS pin (found within ws_boards.h)
   if (!did_init) {
     if (InitSdCard(SD_CS_PIN)) {
 // Attempt to update the config file with the default pin

src/ws_boards.h

@@ -203,16 +203,6 @@
 #define USE_PSRAM ///< Board has PSRAM, use it for dynamic memory allocation
 #define I2c_STEMMA_WIRE1
 #define SD_CS_PIN 33
-#elif defined(ARDUINO_SAMD_NANO_33_IOT)
-#define BOARD_ID "nano-33-iot"
-#define USE_STATUS_LED
-#define STATUS_LED_PIN 13
-#define SD_CS_PIN 33
-#elif defined(ARDUINO_SAMD_MKRWIFI1010)
-#define BOARD_ID "mkrwifi1010"
-#define USE_STATUS_LED
-#define STATUS_LED_PIN 6
-#define SD_CS_PIN 33
 #elif defined(ARDUINO_RASPBERRY_PI_PICO_W)
 #define BOARD_ID "rpi-pico-w"
 #define USE_TINYUSB