Run rubocop

Author: grzegorz-jakubiak

.rubocop.yml

@@ -71,6 +71,7 @@ Naming/PredicateName:
   AllowedMethods:
     - has_many
     - has_many_actions
+    - is_association?
 
 Style/TrailingCommaInArguments:
   Enabled: true

activeadmin-mongoid.gemspec

@@ -1,5 +1,4 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'active_admin/mongoid/version'
 
@@ -10,7 +9,7 @@ Gem::Specification.new do |gem|
   gem.summary       = %q{ActiveAdmin hacks to support Mongoid}
   gem.homepage      = ''
 
-  gem.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  gem.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   gem.files         = `git ls-files`.split("\n")
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   gem.name          = 'activeadmin-mongoid'
@@ -24,7 +23,7 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'activeadmin', '>= 1.4.3'
   gem.add_runtime_dependency 'kaminari-mongoid'
   gem.add_runtime_dependency 'jquery-rails'
-  gem.add_runtime_dependency 'sass-rails',  ['>= 3.1.4']
+  gem.add_runtime_dependency 'sass-rails', ['>= 3.1.4']
 
-  gem.add_development_dependency 'rspec-rails',  '~> 3.6'
+  gem.add_development_dependency 'rspec-rails', '~> 3.6'
 end

lib/active_admin/mongoid/association/relatable.rb

@@ -11,4 +11,4 @@ def foreign_key
     return if embeds?
     foreign_key.to_sym rescue nil
   end
-end
+end

lib/active_admin/mongoid/controllers/resource_controller.rb

@@ -1,7 +1,6 @@
 require 'active_admin/engine'
 
 ActiveAdmin::Engine.module_eval do
-
   initializer 'active_admin.mongoid.resource_controller' do
     class ActiveAdmin::ResourceController
       def build_new_resource

lib/active_admin/mongoid/criteria.rb

@@ -19,4 +19,3 @@ def from(*a)
     end
   end
 end
-

lib/active_admin/mongoid/csv_builder.rb

@@ -11,7 +11,7 @@ def build(controller, csv)
       csv << bom if bom
 
       if column_names
-        csv << CSV.generate_line(columns.map{ |c| encode c.name, options }, csv_options)
+        csv << CSV.generate_line(columns.map { |c| encode c.name, options }, csv_options)
       end
 
       (1..paginated_collection.total_pages).each do |page|

lib/active_admin/mongoid/document.rb

@@ -3,9 +3,6 @@
 module ActiveAdmin::Mongoid::Document
   extend ActiveSupport::Concern
 
-
-
-
   # PROXY CLASSES
 
   class ColumnWrapper < SimpleDelegator
@@ -30,9 +27,6 @@ def quote_column_name name
     end
   end
 
-
-
-
   # CLASS METHODS
 
   included do
@@ -47,7 +41,6 @@ class << self
     def column_for_attribute(name)
       self.class.fields[name.to_sym]
     end
-
   end
 
   module ClassMethods
@@ -63,7 +56,7 @@ def connection
     end
 
     def find_by_id id
-      find_by(:_id => id)
+      find_by(_id: id)
     end
 
     def quoted_table_name
@@ -74,7 +67,6 @@ def associations
       @associations ||= new.associations
     end
 
-
     def reflections *a
       relations *a
     end

lib/active_admin/mongoid/filter_form_builder.rb

@@ -9,11 +9,11 @@ def filter(method, options = {})
   def default_input_type(method, options = {})
     if column = column_for(method)
       case column.type.name.downcase.to_sym
-      when :date, :datetime, :time;   :date_range
-      when :string, :text, :object;  :string
-      when :float, :decimal;          :numeric
+      when :date, :datetime, :time; :date_range
+      when :string, :text, :object; :string
+      when :float, :decimal; :numeric
       when :integer
-        return :select if reflection_for(method.to_s.gsub('_id','').to_sym)
+        return :select if reflection_for(method.to_s.gsub('_id', '').to_sym)
         return :numeric
       end
     elsif is_association?(method)

lib/active_admin/mongoid/filters/resource_extension.rb

@@ -4,7 +4,7 @@ module ActiveAdmin::Filters::ResourceExtension
   def default_association_filters
     if resource_class.respond_to?(:reflect_on_all_associations)
       without_embedded = resource_class.reflect_on_all_associations.reject { |e| e.embeds? }
-      poly, not_poly = without_embedded.partition{ |r| r.macro == :belongs_to && r.options[:polymorphic] }
+      poly, not_poly = without_embedded.partition { |r| r.macro == :belongs_to && r.options[:polymorphic] }
 
       filters = poly.map(&:foreign_key) + not_poly.map(&:name)
       filters.map &:to_sym

lib/active_admin/mongoid/resource.rb

@@ -6,7 +6,7 @@ class Resource
     #  another.  I'm not going to investigate any deeper, let's just remove the
     #  underscore prefixed fields as was the prior behavior
     def default_filters
-      super.reject { |filter|  filter == :_id }
+      super.reject { |filter| filter == :_id }
     end
 
     module Attributes