use basic types for Column.Default #1032

Fixing error: gob: type types.MyDecimal...

Author: ffffwh

driver/common/common.go

@@ -8,8 +8,6 @@ import (
 	"io/ioutil"
 	"time"
 
-	"github.com/pingcap/tidb/types"
-
 	"github.com/actiontech/dtle/g"
 	"github.com/go-mysql-org/go-mysql/mysql"
 	uuid "github.com/satori/go.uuid"
@@ -63,8 +61,7 @@ type GencodeType interface {
 
 func init() {
 	// "Only types that will be transferred as implementations of interface values need to be registered."
-	gob.Register(types.BinaryLiteral{})
-	gob.Register(types.MyDecimal{})
+	//gob.Register(types.BinaryLiteral{})
 	if g.EnvIsTrue(g.ENV_BIG_MSG_100K) {
 		g.NatsMaxMsg = 100 * 1024 // TODO this does not works
 	}

driver/kafka/kafka2.go

@@ -14,10 +14,8 @@ import (
 	"math/big"
 	"strings"
 
-	"github.com/actiontech/dtle/g"
-	"github.com/pingcap/tidb/types"
-
 	"github.com/actiontech/dtle/driver/common"
+	"github.com/actiontech/dtle/g"
 
 	"strconv"
 
@@ -503,8 +501,7 @@ func NewJsonField(optional bool, field string) *Schema {
 
 func NewBitsField(optional bool, field string, length string, defaultValue interface{}) *Schema {
 	if defaultValue != nil {
-		defaultV := defaultValue.(types.BinaryLiteral)
-		defaultValue = base64.StdEncoding.EncodeToString(defaultV)
+		defaultValue = base64.StdEncoding.EncodeToString(defaultValue.([]byte))
 	}
 	return &Schema{
 		Field:    field,

driver/kafka/kafka3.go

@@ -26,7 +26,6 @@ import (
 	"github.com/actiontech/dtle/g"
 	gomysql "github.com/go-mysql-org/go-mysql/mysql"
 	"github.com/hashicorp/nomad/plugins/drivers"
-	"github.com/pingcap/tidb/types"
 	"github.com/pkg/errors"
 
 	gonats "github.com/nats-io/go-nats"
@@ -1234,7 +1233,7 @@ func kafkaColumnListToColDefs(colList *common.ColumnList, loc *time.Location) (v
 		case mysqlconfig.BitColumnType:
 			if cols[i].ColumnType == "bit(1)" {
 				if defaultValue != nil {
-					if string(defaultValue.(types.BinaryLiteral)) == "\x01" {
+					if string(defaultValue.([]byte)) == "\x01" {
 						defaultValue = true
 					} else {
 						defaultValue = false

driver/mysql/base/utils.go

@@ -10,6 +10,8 @@ import (
 	"bytes"
 	gosql "database/sql"
 	"fmt"
+	"github.com/hashicorp/go-hclog"
+	"github.com/pingcap/tidb/types"
 	"regexp"
 	"strings"
 	"time"
@@ -545,7 +547,18 @@ func GetTableColumnsSqle(sqleContext *sqle.Context, schema string,
 				if !ok {
 					newColumn.Default = nil
 				} else {
-					newColumn.Default = value.GetValue()
+					switch v := value.GetValue().(type) {
+					case int64, uint64, float32, float64, string, []byte:
+						newColumn.Default = v
+					case types.BinaryLiteral:
+						newColumn.Default = []byte(v)
+					case fmt.Stringer:
+						newColumn.Default = v.String()
+					default:
+						newColumn.Default = nil
+						g.Logger.Warn("GetTableColumnsSqle: unknown type for a default value",
+							"schema", schema, "table", table, "type", hclog.Fmt("%T", v))
+					}
 				}
 			case ast.ColumnOptionUniqKey:
 				newColumn.Key = "UNI"

driver/mysql/mysqlconfig/types.go

@@ -69,6 +69,7 @@ type Column struct {
 	IsUnsigned         bool
 	Charset            string
 	Type               ColumnType
+	// Default is currently only used for kafka and limited to basic types.
 	Default            interface{}
 	ColumnType         string
 	Key                string