Skip to content

Commit 2171b89

Browse files
committed
addressing review
1 parent 92ab272 commit 2171b89

File tree

2 files changed

+4
-25
lines changed

2 files changed

+4
-25
lines changed

jslib/core/http/Query.ts

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
export enum Operator {
2-
Equals = '=',
2+
Equals = '',
33
NotEquals = '!=',
44
LessThan = '<',
55
GreaterThan = '>',
66
LessThanOrEqual = '<=',
77
GreaterThanOrEqual = '>=',
8-
Like = 'like',
9-
Includes = 'in'
8+
Like = '_like',
9+
Includes = '_in'
1010
}
1111

1212
export interface QueryParam {
@@ -36,8 +36,7 @@ export class Query {
3636
}: QueryParam): this {
3737
const encodedField = encodeURIComponent(field);
3838
const encodedValue = encodeURIComponent(value);
39-
const operatorSuffix = this.getOperatorSuffix(operator);
40-
this.params[`${encodedField}${operatorSuffix}`] = encodedValue;
39+
this.params[`${encodedField}${operator}`] = encodedValue;
4140
return this;
4241
}
4342

@@ -94,23 +93,4 @@ export class Query {
9493
build(): string {
9594
return new URLSearchParams(this.params).toString();
9695
}
97-
98-
/**
99-
* Gets string suffix for a given operator to be used in a query parameter key.
100-
*
101-
* @param operator The comparison operator enum value.
102-
*/
103-
private getOperatorSuffix(operator: Operator): string {
104-
switch (operator) {
105-
case Operator.Equals: return '';
106-
case Operator.NotEquals: return '!=';
107-
case Operator.LessThan: return '<';
108-
case Operator.GreaterThan: return '>';
109-
case Operator.LessThanOrEqual: return '<=';
110-
case Operator.GreaterThanOrEqual: return '>=';
111-
case Operator.Like: return '_like';
112-
case Operator.Includes: return '_in';
113-
default: return '';
114-
}
115-
}
11696
}

modules/acknowledgements/jsx/acknowledgementsIndex.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ class AcknowledgementsIndex extends Component {
110110
const client = new Acknowledgement.Client();
111111
try {
112112
const acknowledgements = await client.get(query);
113-
console.log({acknowledgements}, {depth: null, colors: true});
114113
this.setState({data: {...acknowledgements}});
115114
} catch (error) {
116115
this.setState({error: true});

0 commit comments

Comments
 (0)