More test coverage.

Author: judgej

tests/Message/DPMCompleteRequestTest.php

@@ -2,6 +2,10 @@
 
 namespace Omnipay\AuthorizeNet\Message;
 
+/**
+ * The CompleteRequest object is invoked in the callback handler.
+ */
+
 use Omnipay\Tests\TestCase;
 
 class DPMCompleteAuthorizeRequestTest extends TestCase
@@ -21,21 +25,19 @@ public function testGetDataInvalid()
         $this->request->getData();
     }
 
-    public function testGetHash()
+    public function testGetDpmHash()
     {
         $this->assertSame(md5(''), $this->request->getHash());
 
         $this->request->setHashSecret('hashsec');
         $this->request->setApiLoginId('apilogin');
-        $this->request->setTransactionId('trnid');
-        $this->request->setAmount('10.00');
 
-        $this->assertSame(md5('hashsecapilogintrnid10.00'), $this->request->getHash());
+        $this->assertSame(md5('hashsec' . 'apilogin' . 'trnid' . '10.00'), $this->request->getDpmHash('trnid', '10.00'));
     }
 
     public function testSend()
     {
-        // Note: the hash contains no data supplied by the merchant site, apart
+        // The hash contains no data supplied by the merchant site, apart
         // from the secret. This is the first point at which we see the transaction
         // reference (x_trans_id), and this hash is to validate that the reference and
         // the amount have not be tampered with en-route.
@@ -50,13 +52,39 @@ public function testSend()
         );
         $this->request->setApiLoginId('user');
         $this->request->setHashSecret('shhh');
-        //$this->request->setAmount('10.00');
-        //$this->request->setTransactionReference('12345');
+
+        $this->request->setAmount('10.00');
 
         $response = $this->request->send();
 
         $this->assertTrue($response->isSuccessful());
         $this->assertSame('12345', $response->getTransactionReference());
         $this->assertNull($response->getMessage());
     }
+
+    /**
+     * @expectedException \Omnipay\Common\Exception\InvalidRequestException
+     * @expectedExceptionMessage Incorrect amount
+     */
+    public function testSendWrongAmount()
+    {
+        $this->getHttpRequest()->request->replace(
+            array(
+                'x_response_code' => '1',
+                'x_trans_id' => '12345',
+                'x_amount' => '10.00',
+                'x_MD5_Hash' => strtolower(md5('shhh' . 'user' . '12345' . '10.00')),
+            )
+        );
+        $this->request->setApiLoginId('user');
+        $this->request->setHashSecret('shhh');
+
+        // In the callback, the merchant application sets the amount that
+        // was expected to be authorised. We expected 20.00 but are being
+        // told it was 10.00.
+
+        $this->request->setAmount('20.00');
+
+        $response = $this->request->send();
+    }
 }

tests/Message/DPMCompleteResponseTest.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace Omnipay\AuthorizeNet\Message;
+
+use Omnipay\Tests\TestCase;
+
+class DPMompleteResponseTest extends TestCase
+{
+    public function testSuccess()
+    {
+        $response = new DPMCompleteResponse($this->getMockRequest(), array('x_response_code' => '1', 'x_trans_id' => '12345'));
+
+        $this->assertTrue($response->isSuccessful());
+        $this->assertSame('12345', $response->getTransactionReference());
+        $this->assertNull($response->getMessage());
+    }
+
+    public function testFailure()
+    {
+        $response = new DPMCompleteResponse($this->getMockRequest(), array('x_response_code' => '0', 'x_response_reason_text' => 'Declined'));
+
+        $this->assertFalse($response->isSuccessful());
+        $this->assertNull($response->getTransactionReference());
+        $this->assertSame('Declined', $response->getMessage());
+    }
+}

tests/Mock/DPMAuthorizeFailure.txt

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+CACHE-CONTROL: no-cache
+CONNECTION: close
+PRAGMA: no-cache
+CONTENT-TYPE: application/x-www-form-urlencoded
+ACCEPT: */*
+CONTENT-LENGTH: 739
+HOST: example.com
+
+x_response_code=3&x_response_reason_code=98&x_response_reason_text=%28TESTMODE%29+This+transaction+cannot+be+accepted%2E&x_avs_code=P&x_auth_code=000000&x_trans_id=0&x_method=CC&x_card_type=&x_account_number=&x_first_name=&x_last_name=&x_company=&x_address=&x_city=&x_state=&x_zip=&x_country=&x_phone=&x_fax=&x_email=&x_invoice_num=&x_description=&x_type=auth%5Fonly&x_cust_id=&x_ship_to_first_name=&x_ship_to_last_name=&x_ship_to_company=&x_ship_to_address=&x_ship_to_city=&x_ship_to_state=&x_ship_to_zip=&x_ship_to_country=&x_amount=10%2E00&x_tax=0%2E00&x_duty=0%2E00&x_freight=0%2E00&x_tax_exempt=FALSE&x_po_num=&x_MD5_Hash=480AA04BE6E4BF0469B63D9E42BD568A&x_cvv2_resp_code=&x_cavv_response=&x_test_request=true

tests/Mock/DPMAuthorizeSuccess.txt

@@ -0,0 +1,10 @@
+HTTP/1.1 200 OK
+CACHE-CONTROL: no-cache
+CONNECTION: close
+PRAGMA: no-cache
+CONTENT-TYPE: application/x-www-form-urlencoded
+ACCEPT: */*
+CONTENT-LENGTH: 877
+HOST: example.com
+
+x_response_code=1&x_response_reason_code=1&x_response_reason_text=%28TESTMODE%29+This+transaction+has+been+approved%2E&x_avs_code=P&x_auth_code=000000&x_trans_id=2184493132&x_method=CC&x_card_type=Visa&x_account_number=XXXX4242&x_first_name=Joe&x_last_name=Bloggs&x_company=&x_address=88+Address+2&x_city=City&x_state=State&x_zip=412&x_country=GB&x_phone=01234+567+890&x_fax=&x_email=jason%40academe%2Eco%2Euk&x_invoice_num=975077375&x_description=&x_type=auth%5Fonly&x_cust_id=CUST123&x_ship_to_first_name=Joe&x_ship_to_last_name=Bloggs&x_ship_to_company=&x_ship_to_address=99+Address+2S&x_ship_to_city=CityS&x_ship_to_state=StateS&x_ship_to_zip=412S&x_ship_to_country=GB&x_amount=10%2E00&x_tax=0%2E00&x_duty=0%2E00&x_freight=0%2E00&x_tax_exempt=FALSE&x_po_num=&x_MD5_Hash=480AA04BE6E4BF0469B63D9E42BD568A&x_cvv2_resp_code=&x_cavv_response=&x_test_request=true