Do not validate card if no cvv provided

Author: anush

src/Message/CIMCreateCardRequest.php

@@ -105,6 +105,8 @@ protected function addBillingData(\SimpleXMLElement $data)
             $req->creditCard->expirationDate = $card->getExpiryDate('Y-m');
             if ($card->getCvv()) {
                 $req->creditCard->cardCode = $card->getCvv();
+            } else {
+                $this->setValidationMode(self::VALIDATION_MODE_NONE);
             }
         }
     }

tests/Message/CIMCreateCardRequestTest.php

@@ -8,50 +8,55 @@ class CIMCreateCardRequestTest extends TestCase
 {
     /** @var CIMCreateCardRequest */
     protected $request;
+    private $params;
 
     public function setUp()
     {
         $this->request = new CIMCreateCardRequest($this->getHttpClient(), $this->getHttpRequest());
-        $this->request->initialize(
-            array(
-                'email' => "kaylee@serenity.com",
-                'card' => $this->getValidCard(),
-                'developerMode' => true
-            )
+        $this->params = array(
+            'email' => "kaylee@serenity.com",
+            'card' => $this->getValidCard(),
+            'developerMode' => true
         );
+        $this->request->initialize($this->params);
     }
 
     public function testGetData()
     {
         $data = $this->request->getData();
-        $card = $this->getValidCard();
+        $card = $this->params['card'];
         $this->assertEquals('12345', $data->profile->paymentProfiles->billTo->zip);
         $this->assertEquals($card['number'], $data->profile->paymentProfiles->payment->creditCard->cardNumber);
         $this->assertEquals('testMode', $data->validationMode);
     }
 
     public function testGetDataShouldHaveCustomBillTo()
     {
-        $card = $this->getValidCard();
-        unset($card['billingAddress1']);
-        unset($card['billingAddress2']);
-        unset($card['billingCity']);
-        $this->request->initialize(
-            array(
-                'email' => "kaylee@serenity.com",
-                'card' => $card,
-                'developerMode' => true,
-                'forceCardUpdate' => true,
-                'defaultBillTo' => array(
-                    'address' => '1234 Test Street',
-                    'city' => 'Blacksburg'
-                )
-            )
+        unset($this->params['card']['billingAddress1']);
+        unset($this->params['card']['billingAddress2']);
+        unset($this->params['card']['billingCity']);
+        $this->params['forceCardUpdate'] = true;
+        $this->params['defaultBillTo'] = array(
+            'address' => '1234 Test Street',
+            'city' => 'Blacksburg'
         );
+        $this->request->initialize($this->params);
 
         $data = $this->request->getData();
+
         $this->assertEquals('12345', $data->profile->paymentProfiles->billTo->zip);
         $this->assertEquals('1234 Test Street', $data->profile->paymentProfiles->billTo->address);
         $this->assertEquals('Blacksburg', $data->profile->paymentProfiles->billTo->city);
     }
+
+    public function testGetDataShouldSetValidationModeToNoneIfNoCvvProvided()
+    {
+        unset($this->params['card']['cvv']);
+        $this->request->initialize($this->params);
+
+        $data = $this->request->getData();
+
+        $this->assertFalse(isset($data->profile->paymentProfiles->payment->creditCard->cardCode));
+        $this->assertEquals(CIMCreatePaymentProfileRequest::VALIDATION_MODE_NONE, $this->request->getValidationMode());
+    }
 }