test: Add eslint chai rules and fix issue where some tests weren't being run

Author: TimothyJones

.eslintrc

@@ -1,6 +1,14 @@
 {
-  "extends": "standard",
+  "extends": ["standard", "plugin:mocha/recommended"],
+  "plugins": [
+    "mocha",
+    "@fintechstudios/eslint-plugin-chai-as-promised",
+  ],
   "rules": {
-    "no-var": "error"
+    "no-var": "error",
+    "mocha/max-top-level-suites": "off",
+    "mocha/no-setup-in-describe": "off",
+    "@fintechstudios/chai-as-promised/no-unhandled-promises": "error",
+    "@fintechstudios/chai-as-promised/no-await-in-condition": "error"
   }
 }

package-lock.json

@@ -55,11 +55,13 @@
     "yargs": "^17.7.2"
   },
   "devDependencies": {
+    "@fintechstudios/eslint-plugin-chai-as-promised": "^3.1.0",
     "chai": "^4.3.10",
     "chai-as-promised": "^7.1.1",
     "eslint": "^8.52.0",
     "eslint-config-standard": "^17.1.0",
     "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-mocha": "^10.2.0",
     "eslint-plugin-n": "^15.2.0",
     "eslint-plugin-promise": "^6.1.1",
     "mocha": "^10.2.0",

package.json

@@ -64,7 +64,7 @@ function mock ({ bump, changelog, tags } = {}) {
   return () => stdMocks.flush()
 }
 
-describe('config files', () => {
+describe('config files', function () {
   beforeEach(function () {
     shell.rm('-rf', 'tmp')
     shell.config.silent = true