Address review comments

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

src/python_inspector/resolve_cli.py

@@ -322,7 +322,7 @@ def resolve_dependencies(
             click.secho(f" {repo}")
 
     # resolve dependencies proper
-    requirements, resolved_dependencies, packages = resolve(
+    requirements, resolved_dependencies, purls = resolve(
         direct_dependencies=direct_dependencies,
         environment=environment,
         repos=repos,
@@ -355,10 +355,10 @@ def resolve_dependencies(
         errors=[],
     )
 
-    metadata = []
+    packages = []
 
-    for package in packages:
-        metadata.extend(
+    for package in purls:
+        packages.extend(
             list(get_pypi_data_from_purl(package, repos=repos, environment=environment)),
         )
 
@@ -368,7 +368,7 @@ def resolve_dependencies(
             requirements=requirements,
             resolved_dependencies=resolved_dependencies,
             json_output=json_output,
-            metadata=metadata,
+            packages=packages,
         )
 
     else:
@@ -377,7 +377,7 @@ def resolve_dependencies(
             requirements=requirements,
             resolved_dependencies=resolved_dependencies,
             json_output=pdt_output,
-            metadata=metadata,
+            packages=packages,
             pdt_output=True,
         )
 
@@ -443,7 +443,7 @@ def get_requirements_from_direct_dependencies(
 
 
 def write_output(
-    headers, requirements, resolved_dependencies, json_output, metadata, pdt_output=False
+    headers, requirements, resolved_dependencies, json_output, packages, pdt_output=False
 ):
     """
     Write headers, requirements and resolved_dependencies as JSON to ``json_output``.
@@ -455,12 +455,12 @@ def write_output(
             headers=headers,
             requirements=requirements,
             resolved_dependencies=resolved_dependencies,
-            metadata=metadata,
+            packages=packages,
         )
     else:
         output = dict(
             resolved_dependencies=resolved_dependencies,
-            metadata=metadata,
+            packages=packages,
         )
 
     json.dump(output, json_output, indent=2)

tests/data/default-url-expected.json

@@ -32,5 +32,5 @@
       "dependencies": []
     }
   ],
-  "metadata": []
+  "packages": []
 }

tests/data/environment-marker-test-requirements.txt-expected.json

@@ -39,7 +39,7 @@
       ]
     }
   ],
-  "metadata": [
+  "packages": [
     {
       "type": "pypi",
       "namespace": null,

tests/data/frozen-requirements.txt-expected.json

@@ -722,7 +722,7 @@
       ]
     }
   ],
-  "metadata": [
+  "packages": [
     {
       "type": "pypi",
       "namespace": null,

tests/data/pdt-requirements.txt-expected.json

@@ -39,7 +39,7 @@
       ]
     }
   ],
-  "metadata": [
+  "packages": [
     {
       "type": "pypi",
       "namespace": null,

tests/data/pinned-pdt-requirements.txt-expected.json

@@ -273,7 +273,7 @@
       "dependencies": []
     }
   ],
-  "metadata": [
+  "packages": [
     {
       "type": "pypi",
       "namespace": null,

tests/data/pinned-requirements.txt-expected.json

@@ -805,7 +805,7 @@
       "dependencies": []
     }
   ],
-  "metadata": [
+  "packages": [
     {
       "type": "pypi",
       "namespace": null,

tests/data/setup/simple-setup.py-expected.json

@@ -37,7 +37,7 @@
       ]
     }
   ],
-  "metadata": [
+  "packages": [
     {
       "type": "pypi",
       "namespace": null,

tests/data/single-url-except-simple-expected.json

@@ -73,7 +73,7 @@
       "dependencies": []
     }
   ],
-  "metadata": [
+  "packages": [
     {
       "type": "pypi",
       "namespace": null,

tests/data/single-url-expected.json

@@ -32,7 +32,7 @@
       "dependencies": []
     }
   ],
-  "metadata": [
+  "packages": [
     {
       "type": "pypi",
       "namespace": null,