Add tests

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Author: TG1999

src/python_inspector/resolve_cli.py

@@ -247,7 +247,8 @@ def resolve_dependencies(
             python_requires=python_requires,
         ):
             click.secho(
-                f"Python version {python_version} is not compatible with setup.py {setup_py_file} "
+                f"Python version {get_python_version_from_env_tag(python_version)} "
+                f"is not compatible with setup.py {setup_py_file} "
                 f"python_requires {python_requires}",
                 err=True,
             )

tests/data/setup/simple-setup.py

@@ -1,3 +1,20 @@
+# Copyright (C) 2017-2021 HERE Europe B.V.
+
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+
+# https://www.apache.org/licenses/LICENSE-2.0
+
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# SPDX-License-Identifier: Apache-2.0
+# License-Filename: LICENSE
+
 from setuptools import find_packages
 from setuptools import setup
 
@@ -8,7 +25,7 @@
     url="https://example.org/app",
     license="MIT License",
     classifiers=["License :: OSI Approved :: MIT License", "Programming Language :: Python :: 2"],
-    python_requires=">=2, <3",
-    install_requires=["Flask>=0.12, <1.1"],
+    python_requires=">2, <=3",
+    install_requires=["license-expression>=0.1, <1.2"],
     packages=find_packages(),
 )

tests/data/setup/simple-setup.py-expected.json

@@ -0,0 +1,48 @@
+{
+  "headers": {
+    "tool_name": "python-inspector",
+    "tool_homepageurl": "https://github.com/nexB/python-inspector",
+    "tool_version": "0.6.3",
+    "options": [
+      "--index-url https://pypi.org/simple",
+      "--python-version 27",
+      "--operating-system linux",
+      "--json <file>"
+    ],
+    "notice": "Dependency tree generated with python-inspector.\npython-inspector is a free software tool from nexB Inc. and others.\nVisit https://github.com/nexB/scancode-toolkit/ for support and download.",
+    "warnings": [],
+    "errors": []
+  },
+  "requirements": [
+    {
+      "purl": "pkg:pypi/license-expression",
+      "extracted_requirement": "license-expression<1.2,>=0.1",
+      "scope": "install",
+      "is_runtime": true,
+      "is_optional": false,
+      "is_resolved": false,
+      "resolved_package": {},
+      "extra_data": {}
+    }
+  ],
+  "resolved_dependencies": [
+    {
+      "package": "pkg:pypi/boolean-py@3.8",
+      "dependencies": [],
+      "wheel_urls": [
+        "https://files.pythonhosted.org/packages/eb/5b/f82983127b1a1a4db83ee290e00a94a2b08c566fa6c58466e82ed7b0a76f/boolean.py-3.8-py2.py3-none-any.whl"
+      ],
+      "sdist_url": "https://files.pythonhosted.org/packages/a1/eb/b37ef5647243ade8308f7bb46b1a45e6204790c163cbd8cf6df990d5c1c1/boolean.py-3.8.tar.gz"
+    },
+    {
+      "package": "pkg:pypi/license-expression@1.0",
+      "dependencies": [
+        "pkg:pypi/boolean-py@3.8"
+      ],
+      "wheel_urls": [
+        "https://files.pythonhosted.org/packages/12/7a/dd02b8ac8f0cd81557012b8f249ba4d0d32fe8f98e8d951ebc882187fd92/license_expression-1.0-py2.py3-none-any.whl"
+      ],
+      "sdist_url": "https://files.pythonhosted.org/packages/27/71/a8d8d78f7866a75f6a940cc53d1557a5edf1ae4a281fe8797cf36077105d/license-expression-1.0.tar.gz"
+    }
+  ]
+}

tests/test_cli.py

@@ -25,6 +25,8 @@
 
 test_env = FileDrivenTesting()
 test_env.test_data_dir = os.path.join(os.path.dirname(__file__), "data")
+setup_test_env = FileDrivenTesting()
+setup_test_env.test_data_dir = os.path.join(os.path.dirname(__file__), "data", "setup")
 
 
 @pytest.mark.online
@@ -212,6 +214,31 @@ def test_cli_with_pinned_requirements_file():
     )
 
 
+@pytest.mark.online
+def test_cli_with_setup_py_failure():
+    setup_py_file = setup_test_env.get_test_loc("simple-setup.py")
+    expected_file = setup_test_env.get_test_loc("simple-setup.py-expected.json", must_exist=False)
+    check_setup_py_resolution(
+        setup_py=setup_py_file,
+        expected_file=expected_file,
+        regen=REGEN_TEST_FIXTURES,
+        expected_rc=1,
+        message=f"Python version 3.8 is not compatible with setup.py {setup_py_file} python_requires >2, <=3",
+    )
+
+
+@pytest.mark.online
+def test_cli_with_setup_py():
+    setup_py_file = setup_test_env.get_test_loc("simple-setup.py")
+    expected_file = setup_test_env.get_test_loc("simple-setup.py-expected.json", must_exist=False)
+    check_setup_py_resolution(
+        setup_py=setup_py_file,
+        expected_file=expected_file,
+        regen=REGEN_TEST_FIXTURES,
+        extra_options=["--python-version", "27"],
+    )
+
+
 def check_specs_resolution(
     specifier,
     expected_file,
@@ -276,6 +303,30 @@ def check_requirements_resolution(
     )
 
 
+def check_setup_py_resolution(
+    setup_py,
+    expected_file,
+    extra_options=tuple(),
+    regen=REGEN_TEST_FIXTURES,
+    pdt_output=False,
+    expected_rc=0,
+    message="",
+):
+    result_file = setup_test_env.get_temp_file(file_name="json")
+    if pdt_output:
+        options = ["--setup-py", setup_py, "--json-pdt", result_file]
+    else:
+        options = ["--setup-py", setup_py, "--json", result_file]
+    options.extend(extra_options)
+    result = run_cli(options=options, expected_rc=expected_rc)
+    if message:
+        assert message in result.output
+    if expected_rc == 0:
+        check_json_results(
+            result_file=result_file, expected_file=expected_file, regen=regen, clean=not pdt_output
+        )
+
+
 def check_json_results(result_file, expected_file, clean=True, regen=REGEN_TEST_FIXTURES):
     """
     Check the ``result_file`` JSON results against the ``expected_file``

tests/test_packagecode_pypi.py

@@ -0,0 +1,19 @@
+#
+# Copyright (c) nexB Inc. and others. All rights reserved.
+# ScanCode is a trademark of nexB Inc.
+# SPDX-License-Identifier: Apache-2.0
+# See http://www.apache.org/licenses/LICENSE-2.0 for the license text.
+# See https://github.com/nexB/skeleton for support or download.
+# See https://aboutcode.org for more information about nexB OSS projects.
+#
+
+from _packagedcode.models import DependentPackage
+from _packagedcode.pypi import create_dependency_for_python_requires
+
+
+def test_create_dependency_for_python_requires():
+    assert create_dependency_for_python_requires(
+        python_requires_specifier=">=3.6"
+    ) == DependentPackage(
+        purl="pkg:generic/python", extracted_requirement="python_requires>=3.6", scope="python"
+    )

tests/test_resolution.py

@@ -145,7 +145,7 @@ def test_without_supported_wheels():
         "pkg:pypi/hyperlink@21.0.0",
         "pkg:pypi/idna@3.3",
         "pkg:pypi/pycparser@2.21",
-        "pkg:pypi/setuptools@65.1.0",
+        "pkg:pypi/setuptools@65.2.0",
         "pkg:pypi/txaio@22.2.1",
     ]
 

tests/test_setup_py_parsing.py

@@ -0,0 +1,30 @@
+#
+# Copyright (c) nexB Inc. and others. All rights reserved.
+# ScanCode is a trademark of nexB Inc.
+# SPDX-License-Identifier: Apache-2.0
+# See http://www.apache.org/licenses/LICENSE-2.0 for the license text.
+# See https://github.com/nexB/skeleton for support or download.
+# See https://aboutcode.org for more information about nexB OSS projects.
+#
+
+import os
+
+from _packagedcode.models import DependentPackage
+from _packagedcode.pypi import PythonSetupPyHandler
+
+BASE_DIR = os.path.dirname(os.path.abspath(__file__))
+
+
+def test_setup_py_parsing():
+    setup_py_file = os.path.join(BASE_DIR, "data", "setup", "simple-setup.py")
+    package_data = list(PythonSetupPyHandler.parse(location=setup_py_file))
+    deps = []
+    for pkg in package_data:
+        deps.extend(pkg.dependencies)
+    assert deps == [
+        DependentPackage(
+            purl="pkg:pypi/license-expression",
+            extracted_requirement="license-expression<1.2,>=0.1",
+            scope="install",
+        ),
+    ]

tests/test_utils.py

@@ -21,6 +21,7 @@
 from python_inspector.resolution import fetch_and_extract_sdist
 from python_inspector.utils import get_netrc_auth
 from python_inspector.utils_pypi import PypiSimpleRepository
+from python_inspector.utils_pypi import valid_python_version
 
 test_env = FileDrivenTesting()
 test_env.test_data_dir = os.path.join(os.path.dirname(__file__), "data")
@@ -87,3 +88,8 @@ def test_parse_reqs_with_setup_requires_and_python_requires():
     with open(result_file, "w") as file:
         json.dump(results, file, indent=4)
     check_json_results(result_file, expected_file, clean=False)
+
+
+def test_valid_python_version():
+    assert valid_python_version("3.8", ">3.1")
+    assert not valid_python_version("3.8.1", ">3.9")