Skip to content

Commit d51dc68

Browse files
committed
abort when build error
1 parent b2ef58c commit d51dc68

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

lib/cocoapods-binary/rome/build_framework.rb

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ def build_for_iosish_platform(sandbox,
3030
other_options += ['BITCODE_GENERATION_MODE=bitcode']
3131
end
3232

33-
xcodebuild(sandbox, target_label, device, deployment_target, other_options + custom_build_options)
34-
xcodebuild(sandbox, target_label, simulator, deployment_target, other_options + ['ARCHS=x86_64', 'ONLY_ACTIVE_ARCH=NO'] + custom_build_options_simulator)
33+
is_succeed, _ = xcodebuild(sandbox, target_label, device, deployment_target, other_options + custom_build_options)
34+
is_succeed2, _ = xcodebuild(sandbox, target_label, simulator, deployment_target, other_options + ['ARCHS=x86_64', 'ONLY_ACTIVE_ARCH=NO'] + custom_build_options_simulator)
35+
exit 1 unless is_succeed && is_succeed2
3536

3637
# paths
3738
root_name = target.pod_name
@@ -79,7 +80,11 @@ def xcodebuild(sandbox, target, sdk='macosx', deployment_target=nil, other_optio
7980
platform = PLATFORMS[sdk]
8081
args += Fourflusher::SimControl.new.destination(:oldest, platform, deployment_target) unless platform.nil?
8182
args += other_options
82-
Pod::Executable.execute_command 'xcodebuild', args, true
83+
log = `xcodebuild #{args.join(" ")} 2>&1`
84+
# log = Pod::Executable.execute_command 'xcodebuild', args, true
85+
is_succeed = log[-25..-1].include? "** BUILD SUCCEEDED **"
86+
puts log unless is_succeed
87+
[is_succeed, log]
8388
end
8489

8590

0 commit comments

Comments
 (0)