Commit 5495edd
Move go.mod to Go 1.17
fixes tektoncd#4725 (sorta)
Since tektoncd#4712, we've actually required Go 1.17 to build, but
`go.mod` still was set to `go 1.16`. I noticed this because I have a hack locally that sets the Go
version in the CLI based on what's in `go.mod`, and then couldn't do `go run hack/spec-gen/main.go`.
Given that our CI is all using 1.17 and we require 1.17 to compile/build, we might as well update
`go.mod` as well.
Note that there was one quirk moving to 1.17 - running `go mod tidy` initially got:
```
github.com/tektoncd/pipeline/pkg/apis/config imports
knative.dev/pkg/metrics imports
contrib.go.opencensus.io/exporter/prometheus imports
github.com/prometheus/client_golang/prometheus imports
github.com/cespare/xxhash/v2 loaded from github.com/cespare/xxhash/v2@v2.1.1,
but go 1.16 would select v2.1.2
To upgrade to the versions selected by go 1.16:
go mod tidy -go=1.16 && go mod tidy -go=1.17
If reproducibility with go 1.16 is not needed:
go mod tidy -compat=1.17
For other options, see:
https://golang.org/doc/modules/pruning
```
I took a look, and we already had `github.com/cespare/xxhash/v2@v2.1.2` in `go.sum`, so I decided
that we should do the `go mod tidy -go=1.16 && go mod tidy -go=1.17` approach rather than the
`go mod tidy -compat=1.17` one, to keep the current version we appear to be indirectly referencing.
Also, this means that we don't need to change `hack/update-deps.sh` to have `go mod tidy -compat=1.17`,
because the `go.mod` is now fully 1.17 compatible while having the `xxhash` version we would have
expected.
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>1 parent 7199c26 commit 5495edd
File tree
145 files changed
+377
-6402
lines changed- third_party
- github.com/hashicorp
- errwrap
- go-multierror
- golang-lru
- vendor/golang.org/x
- crypto
- net
- text
- tools
- vendor
- contrib.go.opencensus.io/exporter
- ocagent
- prometheus
- github.com
- Azure/go-autorest
- autorest
- adal
- azure
- auth
- cli
- date
- logger
- tracing
- awslabs/amazon-ecr-credential-helper/ecr-login
- aws
- aws-sdk-go-v2
- config
- credentials
- feature/ec2/imds
- internal
- configsources
- endpoints/v2
- ini
- service
- ecrpublic
- ecr
- internal/presigned-url
- sso
- sts
- smithy-go
- blang/semver/v4
- blendle/zapdriver
- cespare/xxhash/v2
- cloudevents/sdk-go/v2
- containerd/stargz-snapshotter/estargz
- dimchansky/utfbom
- evanphx/json-patch/v5
- go-kit/log
- go-logfmt/logfmt
- go-logr/logr
- go-openapi
- jsonpointer
- jsonreference
- swag
- gobuffalo/flect
- golang-jwt/jwt/v4
- google
- go-containerregistry/pkg/authn
- k8schain
- kubernetes
- gofuzz
- uuid
- hashicorp
- errwrap
- go-multierror
- golang-lru
- imdario/mergo
- jmespath/go-jmespath
- josharian/intern
- json-iterator/go
- kelseyhightower/envconfig
- klauspost/compress
- mitchellh
- copystructure
- go-homedir
- reflectwalk
- modern-go/reflect2
- opencontainers/go-digest
- prometheus/procfs
- sirupsen/logrus
- spf13/pflag
- tektoncd/plumbing
- go.opencensus.io
- go.uber.org
- atomic
- multierr
- zap
- golang.org/x
- oauth2
- term
- xerrors
- gomodules.xyz/jsonpatch/v2
- google.golang.org
- appengine
- grpc
- gopkg.in
- yaml.v2
- yaml.v3
- k8s.io/klog
- v2
- sigs.k8s.io
- json
- yaml
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
145 files changed
+377
-6402
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| 35 | + | |
| 36 | + | |
35 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
36 | 72 | | |
| 73 | + | |
| 74 | + | |
37 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
38 | 86 | | |
| 87 | + | |
| 88 | + | |
39 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
40 | 99 | | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
41 | 122 | | |
42 | 123 | | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
43 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
44 | 136 | | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
45 | 149 | | |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
0 commit comments