Skip to content

Fix styling bugs and edge cases in theme components #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix styling bugs and edge cases in theme components #3

wants to merge 1 commit into from

Conversation

@google-labs-jules
Copy link
Contributor

@google-labs-jules google-labs-jules bot commented Nov 27, 2025

This PR addresses several bugs and edge cases identified during a review of the theme codebase:

  1. Copy Button Selectors: The previous implementation used a single string for selectors, which caused Stylus to generate incorrect global selectors or fail to scope them properly to #content. This was fixed by converting the variable to a Stylus list. Additionally, overly generic classes (.copy, .clipboard) were removed to avoid styling unrelated elements.
  2. Input Elements: The button-ripple mixin created pseudo-elements on <input> tags, which is invalid/unsupported and could cause visual issues. The mixin now excludes input elements.
  3. Positioning: #content was missing position: relative, which caused absolute positioned elements (like the copy buttons) to potentially be positioned relative to the body or viewport.
  4. Table Layout: .wikitable was forced to width: 100%, which looked bad for small tables. It is now set to width: auto with max-width: 100% for better responsiveness.

PR created automatically by Jules for task 14511435312204137624 started by @aaronedev

@google-labs-jules
Fix theme bugs and edge cases
cead8e6 
- Updated copy button selectors to use a Stylus list for correct iteration and scoping.
- Removed generic classes like `.copy` from copy button selectors to prevent false positives.
- Fixed `button-ripple` mixin to exclude `input` elements, preventing visual artifacts.
- Added `position: relative` to `#content` to ensure absolute positioned children are contained correctly.
- Changed table width to `width: auto` and `max-width: 100%` to prevent small tables from stretching unpleasantly.
@google-labs-jules
Copy link
Contributor Author

google-labs-jules bot commented Nov 27, 2025

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants