react-native-navigation (wix) fix (#18)

* added forceApplicationToQuit parameter

* adapted native module

* finish crashed activity after start error activity

* Update README.md

* Added verification to OS

As iOS module did not changed the signature, we will only apply the callback to it, ignoring other parameter that fix the react-native-navigation problem

Author: faogustavo

README.md

@@ -381,6 +381,14 @@ setNativeExceptionHandler((errorString) => {
 *More Examples can be found in the examples folder*
 - Preserving old handler (thanks to zeh)
 
+#### react-native-navigation (Wix)
+
+When you use the [wix library](http://wix.github.io/react-native-navigation/) to navigate, you need to add a *false* parameter to _setNativeExceptionHandler_. Otherwise it will recreate the application above the crash screen.
+
+```js
+setNativeExceptionHandler(nativeErrorCallback, false);
+```
+
 
 ## CONTRIBUTORS
 - [Atul R](https://github.com/master-atul)

android/src/main/java/com/masteratul/exceptionhandler/ReactNativeExceptionHandlerModule.java

@@ -14,6 +14,7 @@ public class ReactNativeExceptionHandlerModule extends ReactContextBaseJavaModul
   private ReactApplicationContext reactContext;
     private Activity activity;
     private static Class errorIntentTargetClass = DefaultErrorScreen.class;
+    private boolean forceToQuit;
     private Callback callbackHolder;
 
     public ReactNativeExceptionHandlerModule(ReactApplicationContext reactContext) {
@@ -28,21 +29,31 @@ public String getName() {
 
 
   @ReactMethod
-  public void setHandlerforNativeException(Callback customHandler){
-      callbackHolder = customHandler;
+  public void setHandlerforNativeException(final boolean forceToQuit, Callback customHandler){
+      this.callbackHolder = customHandler;
+      this.forceToQuit = forceToQuit;
+    
       Thread.setDefaultUncaughtExceptionHandler(new Thread.UncaughtExceptionHandler() {
           @Override
           public void uncaughtException(Thread thread, Throwable throwable) {
               activity = getCurrentActivity();
               String stackTraceString = Log.getStackTraceString(throwable);
               callbackHolder.invoke(stackTraceString);
-              Log.d("ERROR",stackTraceString);
+            
+              if (BuildConfig.DEBUG) {
+                  Log.d("ERROR",stackTraceString);
+              }
+            
               Intent i = new Intent();
               i.setClass(activity, errorIntentTargetClass);
               i.putExtra("stack_trace_string",stackTraceString);
               i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+            
               activity.startActivity(i);
-              System.exit(0);
+              activity.finish();
+            
+              if (forceToQuit)
+                System.exit(0);
           }
       });
   }

index.js

@@ -1,5 +1,5 @@
 
-import {NativeModules} from 'react-native';
+import {NativeModules, Platform} from 'react-native';
 
 const {ReactNativeExceptionHandler} = NativeModules;
 
@@ -17,11 +17,16 @@ export const setJSExceptionHandler = (customHandler = noop, allowedInDevMode = f
 
 export const getJSExceptionHandler = () => global.ErrorUtils.getGlobalHandler();
 
-export const setNativeExceptionHandler = (customErrorHandler = noop) => {
+export const setNativeExceptionHandler = (customErrorHandler = noop, forceApplicationToQuit = true) => {
   if (typeof customErrorHandler !== 'function') {
     customErrorHandler = noop;
   }
-  ReactNativeExceptionHandler.setHandlerforNativeException(customErrorHandler);
+  
+  if (Platform.OS === 'ios') {
+    ReactNativeExceptionHandler.setHandlerforNativeException(customErrorHandler);
+  } else {
+    ReactNativeExceptionHandler.setHandlerforNativeException(forceApplicationToQuit, customErrorHandler);
+  }
 };
 
 export default {