-
Notifications
You must be signed in to change notification settings - Fork 273
chore(client): Expose BaseClient from a2a.client package #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(client): Expose BaseClient from a2a.client package #529
Conversation
Summary of ChangesHello @martimfasantos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request exposes the BaseClient class from the a2a.client package. The changes in src/a2a/client/__init__.py correctly add the import for BaseClient and include it in the __all__ list. The modifications are consistent with the existing code style and structure of the file. The change is straightforward and I have no suggestions for improvement.
|
@martimfasantos What is the use case for this? Is it for allowing developers to create their own clients? |
|
@holtskinner Exactly! Not only does it let you implement a customized client, but it also allows you to add the type to the return value of |
Description
This pull request introduces a minor update to the
src/a2a/client/__init__.pyfile, focusing on the module's imports. The change makes theBaseClientclass available for import from this package.BaseClientto the list of imported symbols and to the module's__all__, making it accessible when importing froma2a.client. [1] [2]CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)