Pass hints through in RelyingParty.startAssertion

Author: emlun

webauthn-server-core/src/main/java/com/yubico/webauthn/RelyingParty.java

@@ -538,7 +538,8 @@ public AssertionRequest startAssertion(StartAssertionOptions startAssertionOptio
                 startAssertionOptions
                     .getExtensions()
                     .merge(startAssertionOptions.getExtensions().toBuilder().appid(appId).build()))
-            .timeout(startAssertionOptions.getTimeout());
+            .timeout(startAssertionOptions.getTimeout())
+            .hints(startAssertionOptions.getHints());
 
     startAssertionOptions.getUserVerification().ifPresent(pkcro::userVerification);
 

webauthn-server-core/src/test/scala/com/yubico/webauthn/RelyingPartyStartOperationSpec.scala

@@ -818,6 +818,59 @@ class RelyingPartyStartOperationSpec
         }
       }
 
+      describe("allows setting the hints") {
+        val rp = relyingParty(userId = userId)
+
+        it("to string values in the spec or not.") {
+          val pkcro = rp.startAssertion(
+            StartAssertionOptions
+              .builder()
+              .hints("hej", "security-key", "hoj", "client-device", "hybrid")
+              .build()
+          )
+          pkcro.getPublicKeyCredentialRequestOptions.getHints.asScala should equal(
+            List(
+              "hej",
+              PublicKeyCredentialHint.SECURITY_KEY.getValue,
+              "hoj",
+              PublicKeyCredentialHint.CLIENT_DEVICE.getValue,
+              PublicKeyCredentialHint.HYBRID.getValue,
+            )
+          )
+        }
+
+        it("to PublicKeyCredentialHint values in the spec or not.") {
+          val pkcro = rp.startAssertion(
+            StartAssertionOptions
+              .builder()
+              .hints(
+                PublicKeyCredentialHint.of("hej"),
+                PublicKeyCredentialHint.HYBRID,
+                PublicKeyCredentialHint.SECURITY_KEY,
+                PublicKeyCredentialHint.of("hoj"),
+                PublicKeyCredentialHint.CLIENT_DEVICE,
+              )
+              .build()
+          )
+          pkcro.getPublicKeyCredentialRequestOptions.getHints.asScala should equal(
+            List(
+              "hej",
+              PublicKeyCredentialHint.HYBRID.getValue,
+              PublicKeyCredentialHint.SECURITY_KEY.getValue,
+              "hoj",
+              PublicKeyCredentialHint.CLIENT_DEVICE.getValue,
+            )
+          )
+        }
+
+        it("or not, defaulting to the empty list.") {
+          val pkcro = rp.startAssertion(StartAssertionOptions.builder().build())
+          pkcro.getPublicKeyCredentialRequestOptions.getHints.asScala should equal(
+            List()
+          )
+        }
+      }
+
       it("allows setting the timeout to empty.") {
         val req = relyingParty(userId = userId).startAssertion(
           StartAssertionOptions