Merge pull request #2 from mediact/feature/MAGE2-92

1.2.0 Remove marketplace standard until it is compatible with PHPCS3

Author: Klaas Sangers

README.md

@@ -1,17 +1,15 @@
 # Introduction
 
-This is the MediaCT coding standard for Magento 2 projects. It is a mix of the
-default MediaCT coding standard and the Magento marketplace standard.
-
-Some tests have been removed from both of the standards to create a workable
-and fast standard.
+This is the MediaCT coding standard for Magento 2 projects. It is based on 
+the default MediaCT coding standard but some tests have been removed to create
+a workable and fast standard.
 
 # Installation
 
 Use composer to require the standard in a project.
 
 ```shell
-$ composer require --dev mediact/coding-standard-magento2
+composer require --dev mediact/coding-standard-magento2
 ```
 
 To let PHPCS know that this standard should be used add a phpcs.xml file in the
@@ -30,12 +28,12 @@ The recommended way to enable the coding standard in PHPStorm and automatic
 testing is by requiring the MediaCT testing suite in a project.
 
 ```shell
-$ composer require --dev mediact/testing-suite
+composer require --dev mediact/testing-suite
 ```
 
 For more information go to [MediaCT Testing Suite](https://github.com/mediact/testing-suite).
 
 # Contribution guidelines
 
 Contributions are welcome. Please create pull requests which add or remove
-tests.
+tests.

composer.json

@@ -10,23 +10,12 @@
       "email": "contact@mediact.nl"
     }
   ],
-  "repositories": [
-    {
-      "type": "composer",
-      "url": "https://composer.mediact.nl"
-    },
-    {
-      "type": "composer",
-      "url": "https://repo.magento.com"
-    }
-  ],
   "require": {
-    "magento/marketplace-eqp": "^1.0",
     "mediact/coding-standard": "@stable"
   },
   "autoload": {
     "psr-0": {
       "MediactMagento2": "src/MediactMagento2"
     }
   }
-}
+}

src/MediactMagento2/ruleset.xml

@@ -5,8 +5,8 @@
  * https://www.mediact.nl
  */
 -->
-<ruleset name="Mediact/Magento1">
-    <description>MediaCT coding standards for Magento1.</description>
+<ruleset name="Mediact/Magento2">
+    <description>MediaCT coding standards for Magento2.</description>
     <arg name="colors" />
     <arg name="extensions" value="php/PHP,phtml/PHP,js/JS,css/CSS" />
 
@@ -25,35 +25,6 @@
         <exclude name="Generic.PHP.Syntax"/>
     </rule>
 
-    <!-- Base rules on Magento Marketplace -->
-    <rule ref="../../../../magento/marketplace-eqp/MEQP1">
-        <exclude name="MEQP1.Classes"/>
-        <exclude name="MEQP1.PHP.PrivateClassMember"/>
-        <exclude name="MEQP1.Exceptions.DirectThrow"/>
-        <exclude name="MEQP1.PHP.Syntax"/>
-        <exclude name="MEQP1.Security.Acl"/>
-        <exclude name="MEQP1.Security.Superglobal"/>
-        <exclude name="MEQP1.Classes.ObjectInstantiation"/>
-        <exclude name="MEQP1.Stdlib.DateTime"/>
-        <exclude name="MEQP1.SQL.MissedIndexes"/>
-        <exclude name="MEQP1.SQL.SlowQuery"/>
-        <exclude name="MEQP1.Security.DiscouragedFunction" />
-        <exclude name="MEQP1.Performance.Loop" />
-        <exclude name="Generic.Functions.OpeningFunctionBraceBsdAllman" />
-        <exclude name="Zend.NamingConventions.ValidVariableName.PrivateNoUnderscore"/>
-    </rule>
-    <rule ref="../../../../magento/marketplace-eqp/MEQP2">
-        <exclude name="PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket"/>
-        <exclude name="MEQP2.PHP.Syntax"/>
-        <exclude name="Generic.Arrays.DisallowShortArraySyntax" />
-        <exclude name="Generic.CodeAnalysis.UnusedFunctionParameter.Found"/>
-    </rule>
-
-    <rule ref="Squiz.PHP.CommentedOutCode">
-        <properties>
-            <property name="maxPercentage" value="80"/>
-        </properties>
-    </rule>
     <rule ref="Generic.Files.LineLength.TooLong">
         <exclude-pattern>*.phtml</exclude-pattern>
     </rule>