Test aigmap conversion consistency #5527
Open
+779
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skips (with warning) on cells that didn't convert to avoid `write_aiger` from raising an error.
Any files that differ (e.g. due to compiler order of operations changing) will trigger an error.
Generated with changes from 26f2c11
Collaborator
|
Nice! But why did the CI not fail? EDIT: oh right we only run tests with clang, only building with gcc is tested in CI |
Member
Author
|
Oh yeah... well, that's less helpful for CI then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
#5526 said it "can't be tested," and I went "challenge accepted."
Explain how this is achieved.
Add
write_aigerlogic totest_cell; if the-aigmapoption is provided while writing output files, callaigmapand write the resulting design to a.aaginstead.Previously,
-aigmapdidn't affect anything if-wwas also provided, but it stands to reason that if we have specifically requested aigmapping we probably want aig files for the gate designs to output instead of the rtlil for the gold designs. But I haven't added anything to the help text since I'm not 100% sure this is the correct approach.Make sure your change comes with tests. If not possible, share how a reviewer might evaluate it.
As-is, this will cause gcc builds to fail testing. I used the changes from 26f2c11 and clang to generate the gold reference files, but it seems like even without those changes the output from a clang build is still the same. However even with the changes from 26f2c11, this still fails on
$_OAI4_for gcc.