Merge pull request #136 from Xvezda/feature/tests

Support type narrowing for non-callable node

Author: Xvezda

src/rules/no-undocumented-throws.js

@@ -143,13 +143,23 @@ module.exports = createRule({
       const calleeDeclaration = getCalleeDeclaration(services, node);
       if (!calleeDeclaration) return;
 
-      const signature = getCallSignature(
-        services,
-        services.tsNodeToESTreeNodeMap.get(calleeDeclaration)
-      );
+      switch (node.type) {
+        case AST_NODE_TYPES.CallExpression:
+        case AST_NODE_TYPES.NewExpression: {
+          if (services.tsNodeToESTreeNodeMap.has(calleeDeclaration)) {
+            const signature = getCallSignature(
+              services,
+              services.tsNodeToESTreeNodeMap.get(calleeDeclaration)
+            );
 
-      const returnType = signature?.getReturnType();
-      if (returnType && isGeneratorLike(returnType)) return;
+            const returnType = signature?.getReturnType();
+            if (returnType && isGeneratorLike(returnType)) return;
+          }
+          break;
+        }
+        default:
+          break;
+      }
 
       /** @type {import('typescript').JSDocThrowsTag[]} */
       const comments = [];

src/utils.js

@@ -350,11 +350,14 @@ const getCalleeDeclaration = (services, node) => {
     const calleeNode = getCallee(node);
     if (!calleeNode) return null;
 
-    const symbol = services
-      .getTypeAtLocation(calleeNode)
-      .symbol;
+    const type = services.getTypeAtLocation(calleeNode);
 
-    if (!symbol || !symbol.valueDeclaration) {
+    if (type.symbol?.valueDeclaration) {
+      declaration = type.symbol.valueDeclaration;
+    } else if (type.symbol?.declarations?.length) {
+      // If there are multiple declarations, we take the first one.
+      declaration = type.symbol.declarations[0];
+    } else {
       const declarations = services
         .getSymbolAtLocation(calleeNode)
         ?.declarations;
@@ -363,8 +366,6 @@ const getCalleeDeclaration = (services, node) => {
 
       // If there are multiple declarations, we take the first one.
       declaration = declarations[0];
-    } else {
-      declaration = symbol.valueDeclaration;
     }
   }
   if (!declaration) return null;