From cc4d99a0470ea851954b7f335f4a208f82c32868 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 19 May 2025 15:41:42 +0000 Subject: [PATCH 1/3] build(deps): bump bignumber.js from 9.1.2 to 9.3.0 Bumps [bignumber.js](https://github.com/MikeMcl/bignumber.js) from 9.1.2 to 9.3.0. - [Release notes](https://github.com/MikeMcl/bignumber.js/releases) - [Changelog](https://github.com/MikeMcl/bignumber.js/blob/main/CHANGELOG.md) - [Commits](https://github.com/MikeMcl/bignumber.js/compare/v9.1.2...v9.3.0) --- updated-dependencies: - dependency-name: bignumber.js dependency-version: 9.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- package-lock.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/package-lock.json b/package-lock.json index 3c865864ac..f20fb610bf 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4098,7 +4098,9 @@ "license": "Apache-2.0" }, "node_modules/bignumber.js": { - "version": "9.1.2", + "version": "9.3.0", + "resolved": "https://registry.npmjs.org/bignumber.js/-/bignumber.js-9.3.0.tgz", + "integrity": "sha512-EM7aMFTXbptt/wZdMlBv2t8IViwQL+h6SLHosp8Yf0dqJMTnY6iL32opnAB6kAdL0SZPuvcAzFr31o0c/R3/RA==", "license": "MIT", "engines": { "node": "*" From bf4500f9677c6c44758631ef3ec2adea9ab0d5a8 Mon Sep 17 00:00:00 2001 From: Phu Pham Date: Tue, 3 Jun 2025 17:03:41 -0400 Subject: [PATCH 2/3] fix build error --- packages/xrpl/src/Wallet/signer.ts | 6 ++++-- packages/xrpl/src/sugar/getOrderbook.ts | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/xrpl/src/Wallet/signer.ts b/packages/xrpl/src/Wallet/signer.ts index 126e629cd7..1489e5d38a 100644 --- a/packages/xrpl/src/Wallet/signer.ts +++ b/packages/xrpl/src/Wallet/signer.ts @@ -137,8 +137,10 @@ function getTransactionWithAllSigners( * @returns 1 if left \> right, 0 if left = right, -1 if left \< right, and null if left or right are NaN. */ function compareSigners(left: Signer, right: Signer): number { - return addressToBigNumber(left.Signer.Account).comparedTo( - addressToBigNumber(right.Signer.Account), + return ( + addressToBigNumber(left.Signer.Account).comparedTo( + addressToBigNumber(right.Signer.Account), + ) || 0 ) } diff --git a/packages/xrpl/src/sugar/getOrderbook.ts b/packages/xrpl/src/sugar/getOrderbook.ts index 285a9d8f28..e13be6c4a0 100644 --- a/packages/xrpl/src/sugar/getOrderbook.ts +++ b/packages/xrpl/src/sugar/getOrderbook.ts @@ -17,7 +17,7 @@ function sortOffers(offers: BookOffer[]): BookOffer[] { const qualityA = offerA.quality ?? 0 const qualityB = offerB.quality ?? 0 - return new BigNumber(qualityA).comparedTo(qualityB) + return new BigNumber(qualityA).comparedTo(qualityB) || 0 }) } From e730020eef156245596239849380d03b1c53e61f Mon Sep 17 00:00:00 2001 From: Phu Pham Date: Tue, 3 Jun 2025 17:27:20 -0400 Subject: [PATCH 3/3] use ?? instead --- packages/xrpl/src/Wallet/signer.ts | 2 +- packages/xrpl/src/sugar/getOrderbook.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/xrpl/src/Wallet/signer.ts b/packages/xrpl/src/Wallet/signer.ts index 1489e5d38a..81c8ae6707 100644 --- a/packages/xrpl/src/Wallet/signer.ts +++ b/packages/xrpl/src/Wallet/signer.ts @@ -140,7 +140,7 @@ function compareSigners(left: Signer, right: Signer): number { return ( addressToBigNumber(left.Signer.Account).comparedTo( addressToBigNumber(right.Signer.Account), - ) || 0 + ) ?? 0 ) } diff --git a/packages/xrpl/src/sugar/getOrderbook.ts b/packages/xrpl/src/sugar/getOrderbook.ts index e13be6c4a0..51a9fae494 100644 --- a/packages/xrpl/src/sugar/getOrderbook.ts +++ b/packages/xrpl/src/sugar/getOrderbook.ts @@ -17,7 +17,7 @@ function sortOffers(offers: BookOffer[]): BookOffer[] { const qualityA = offerA.quality ?? 0 const qualityB = offerB.quality ?? 0 - return new BigNumber(qualityA).comparedTo(qualityB) || 0 + return new BigNumber(qualityA).comparedTo(qualityB) ?? 0 }) }