diff --git a/package-lock.json b/package-lock.json index 8e74b3cd44..0652151e29 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4126,7 +4126,9 @@ "license": "Apache-2.0" }, "node_modules/bignumber.js": { - "version": "9.1.2", + "version": "9.3.0", + "resolved": "https://registry.npmjs.org/bignumber.js/-/bignumber.js-9.3.0.tgz", + "integrity": "sha512-EM7aMFTXbptt/wZdMlBv2t8IViwQL+h6SLHosp8Yf0dqJMTnY6iL32opnAB6kAdL0SZPuvcAzFr31o0c/R3/RA==", "license": "MIT", "engines": { "node": "*" diff --git a/packages/xrpl/src/Wallet/signer.ts b/packages/xrpl/src/Wallet/signer.ts index 126e629cd7..81c8ae6707 100644 --- a/packages/xrpl/src/Wallet/signer.ts +++ b/packages/xrpl/src/Wallet/signer.ts @@ -137,8 +137,10 @@ function getTransactionWithAllSigners( * @returns 1 if left \> right, 0 if left = right, -1 if left \< right, and null if left or right are NaN. */ function compareSigners(left: Signer, right: Signer): number { - return addressToBigNumber(left.Signer.Account).comparedTo( - addressToBigNumber(right.Signer.Account), + return ( + addressToBigNumber(left.Signer.Account).comparedTo( + addressToBigNumber(right.Signer.Account), + ) ?? 0 ) } diff --git a/packages/xrpl/src/sugar/getOrderbook.ts b/packages/xrpl/src/sugar/getOrderbook.ts index 285a9d8f28..51a9fae494 100644 --- a/packages/xrpl/src/sugar/getOrderbook.ts +++ b/packages/xrpl/src/sugar/getOrderbook.ts @@ -17,7 +17,7 @@ function sortOffers(offers: BookOffer[]): BookOffer[] { const qualityA = offerA.quality ?? 0 const qualityB = offerB.quality ?? 0 - return new BigNumber(qualityA).comparedTo(qualityB) + return new BigNumber(qualityA).comparedTo(qualityB) ?? 0 }) }