-
Notifications
You must be signed in to change notification settings - Fork 563
Subscribe: Add book_changes
#2980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dangell7
wants to merge
2
commits into
XRPLF:main
Choose a base branch
from
Transia-RnD:book-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
LGTM: 'book_changes' stream type has been added correctly.
The addition of 'book_changes' to the StreamType union type looks good. This change expands the available stream types that can be used with the XRPL library.
Consider adding appropriate documentation to explain what the 'book_changes' stream represents and how it should be used by consumers of the library.
🏁 Script executed:
Length of output: 499
🏁 Script executed:
Length of output: 115
Add documentation for the new
book_changesstream typeI didn’t find any references to
book_changesin your markdown docs (e.g. README.md, MIGRATION.md, etc.), so please add a note about what thebook_changesstream represents and how consumers should use it. For example:• In README.md (under “Streams” or “Websocket Subscriptions”), list
book_changesalongside the existing stream types with a brief description.• In MIGRATION.md (if you document breaking changes or new features), mention that
book_changeswas introduced in this release and point to any relevant examples.