Skip to content

Commit 44e6c75

Browse files
committed
Build/Test Tools: Prevent orphaned Docker containers.
This updates certain local Docker environment commands to include `--rm`, which instructs `docker compose` to remove the container after running the specified scripts. Previously only the installation script contained `--rm`. But running `test:php`, `env:start`, or `env:cli` resulted in the container remaining. Props johnbillion. Fixes #62395. git-svn-id: https://develop.svn.wordpress.org/trunk@59393 602fd350-edb4-49c9-b593-d223f7449a82
1 parent ed0ad98 commit 44e6c75

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,17 +179,17 @@
179179
"grunt": "grunt",
180180
"lint:jsdoc": "wp-scripts lint-js",
181181
"lint:jsdoc:fix": "wp-scripts lint-js --fix",
182-
"env:start": "node ./tools/local-env/scripts/start.js && node ./tools/local-env/scripts/docker.js run -T php composer update -W",
182+
"env:start": "node ./tools/local-env/scripts/start.js && node ./tools/local-env/scripts/docker.js run -T --rm php composer update -W",
183183
"env:stop": "node ./tools/local-env/scripts/docker.js down",
184184
"env:restart": "npm run env:stop && npm run env:start",
185185
"env:clean": "node ./tools/local-env/scripts/docker.js down -v --remove-orphans",
186186
"env:reset": "node ./tools/local-env/scripts/docker.js down --rmi all -v --remove-orphans",
187187
"env:install": "node ./tools/local-env/scripts/install.js",
188-
"env:cli": "node ./tools/local-env/scripts/docker.js run cli",
188+
"env:cli": "node ./tools/local-env/scripts/docker.js run --rm cli",
189189
"env:logs": "node ./tools/local-env/scripts/docker.js logs",
190190
"env:pull": "node ./tools/local-env/scripts/docker.js pull",
191191
"test:performance": "wp-scripts test-playwright --config tests/performance/playwright.config.js",
192-
"test:php": "node ./tools/local-env/scripts/docker.js run php ./vendor/bin/phpunit",
192+
"test:php": "node ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpunit",
193193
"test:coverage": "npm run test:php -- --coverage-html ./coverage/html/ --coverage-php ./coverage/php/report.php --coverage-text=./coverage/text/report.txt",
194194
"test:e2e": "wp-scripts test-playwright --config tests/e2e/playwright.config.js",
195195
"test:visual": "wp-scripts test-playwright --config tests/visual-regression/playwright.config.js",

0 commit comments

Comments
 (0)