Modern Image Formats interfering with image cropping

[Realworld404]

Bug Description

Modern Image Formats seems to cause a problem with uploading and cropping images.

Steps to reproduce

1. Install BuddyBoss plugin
2. Enable Modern Image Formats
3. In Profile Settings, allow users to upload avatars or profile pictures
4. Upload a png or jpg photograph in Edit Profile page
5. Follow instrutions to crop image
6. Error returns
7. Disable Modern IMage Formats & try again, no error.

Screenshots

Additional Context

• PHP Version: 8.2
• OS: MacOS
• Browser: Chrome
• Plugin Version: 2.5.1
• Device: Macbook Pro M4

[b1ink0]

It seems the BuddyBoss plugin does not support modern image formats like WebP or AVIF. In this file (https://github.com/buddyboss/buddyboss-platform/blob/05fa39f8ebe64c72405557df2081ba7d4fe781ec/src/bp-core/classes/class-bp-attachment.php#L503-L517), you can see it only allows PNG and JPEG types. Because the Modern Image Formats plugin converts the uploaded image before BuddyBoss processes it, the crop will always fail due to the lack of support. I think this needs to be fixed on BuddyBoss’s end by adding support for modern image formats.

Error:

Note: This error isn’t logged by default, I had to add error logs to the BuddyBoss plugin to capture it.

Array
(
    [full] => WP_Error Object
        (
            [errors] => Array
                (
                    [crop_error] => Array
                        (
                            [0] => Cropping the file failed: source file is not a supported image file.
                        )

                )

            [error_data] => Array
                (
                )

            [additional_data:protected] => Array
                (
                )

        )

    [thumb] => WP_Error Object
        (
            [errors] => Array
                (
                    [crop_error] => Array
                        (
                            [0] => Cropping the file failed: source file is not a supported image file.
                        )

                )

            [error_data] => Array
                (
                )

            [additional_data:protected] => Array
                (
                )

        )

)

[swissspidy]

Yeah I'd report this to BuddyBoss for sure, a hardcoded list is fragile.