Merge pull request #2242 from WordPress/dependabot/npm_and_yarn/commander-14.0.2

Bump commander from 14.0.1 to 14.0.2

Author: westonruter

package-lock.json

@@ -18,7 +18,7 @@
     "@wordpress/env": "^10.33.0",
     "@wordpress/prettier-config": "^4.33.0",
     "@wordpress/scripts": "^30.26.0",
-    "commander": "14.0.1",
+    "commander": "14.0.2",
     "copy-webpack-plugin": "^13.0.1",
     "css-minimizer-webpack-plugin": "^7.0.2",
     "fast-glob": "^3.3.3",

package.json

@@ -16,12 +16,21 @@
 class Test_OD_REST_URL_Metrics_Store_Endpoint extends WP_UnitTestCase {
 	use Optimization_Detective_Test_Helpers;
 
+	/**
+	 * @var array<string, WP_Post_Type>|null
+	 */
+	protected $original_post_types = null;
+
 	/**
 	 * Sets up.
 	 */
 	public function set_up(): void {
 		parent::set_up();
 		unset( $GLOBALS['wp_rest_server'] );
+
+		// This is needed due to how create_initial_rest_routes() was modified in <https://core.trac.wordpress.org/changeset/61029>. See <https://core.trac.wordpress.org/ticket/62755#comment:21>.
+		global $wp_post_types;
+		$this->original_post_types = $wp_post_types;
 	}
 
 	/**
@@ -30,6 +39,9 @@ public function set_up(): void {
 	public function tear_down(): void {
 		parent::tear_down();
 		unset( $GLOBALS['wp_rest_server'] );
+
+		global $wp_post_types;
+		$wp_post_types = $this->original_post_types;
 	}
 
 	/**

plugins/optimization-detective/tests/storage/test-class-od-rest-url-metrics-store-endpoint.php

@@ -412,10 +412,15 @@ public function test_delete_all_posts(): void {
 		// Create sample posts of all post types other than URL Metrics.
 		$other_post_ids = array();
 		foreach ( array_diff( get_post_types(), array( OD_URL_Metrics_Post_Type::SLUG ) ) as $post_type ) {
-			$other_post_ids = array_merge(
-				$other_post_ids,
-				self::factory()->post->create_many( 10, compact( 'post_type' ) )
-			);
+			for ( $i = 0; $i < 10; $i++ ) {
+				$other_post = self::factory()->post->create_and_get( compact( 'post_type' ) );
+				$this->assertInstanceOf(
+					WP_Post::class,
+					$other_post,
+					"Failed to create post of $post_type post type: " . ( $other_post instanceof WP_Error ? $other_post->get_error_message() : 'Unknown' )
+				);
+				$other_post_ids[] = $other_post->ID;
+			}
 		}
 		foreach ( $other_post_ids as $post_id ) {
 			update_post_meta( $post_id, $other_post_meta_key, $other_post_meta_value );