Skip to content

Commit 87b3997

Browse files
Declare generic EntityStore as parameter type
Store::getEntityStore() (which is where ImportEntities::newEntityImporter() gets the entity store from) has never promised to return more than a generic EntityStore, and with Wikibase commit 91a07a3901 (change I84661212a6), it has started to return a TypeDispatchingEntityStore instead of a WikiPageEntityStore. As far as I can tell, we don’t need anything specific to WikiPageEntityStore, so adjusting the parameter type should be enough to fix this problem.
1 parent dde40a5 commit 87b3997

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/EntityImporter.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
use Wikibase\DataModel\Snak\PropertyValueSnak;
1212
use Wikibase\DataModel\Statement\StatementList;
1313
use Wikibase\Import\Store\ImportedEntityMappingStore;
14-
use Wikibase\Repo\Store\WikiPageEntityStore;
14+
use Wikibase\Lib\Store\EntityStore;
1515

1616
class EntityImporter {
1717

@@ -39,7 +39,7 @@ public function __construct(
3939
StatementsImporter $statementsImporter,
4040
BadgeItemUpdater $badgeItemUpdater,
4141
ApiEntityLookup $apiEntityLookup,
42-
WikiPageEntityStore $entityStore,
42+
EntityStore $entityStore,
4343
ImportedEntityMappingStore $entityMappingStore,
4444
StatementsCountLookup $statementsCountLookup,
4545
LoggerInterface $logger

0 commit comments

Comments
 (0)