Check that no magic values are used

Author: Cito

dbutils/pooled_pg.py

@@ -117,6 +117,10 @@
 from . import __version__
 from .steady_pg import SteadyPgConnection
 
+# constants for "reset" parameter
+RESET_ALWAYS_ROLLBACK = 1
+RESET_COMPLETELY = 2
+
 
 class PooledPgError(Exception):
     """General PooledPg error."""
@@ -214,10 +218,10 @@ def connection(self):
     def cache(self, con):
         """Put a connection back into the pool cache."""
         try:
-            if self._reset == 2:
+            if self._reset == RESET_COMPLETELY:
                 con.reset()  # reset the connection completely
             else:
-                if self._reset or con._transaction:
+                if self._reset == RESET_ALWAYS_ROLLBACK or con._transaction:
                     try:
                         con.rollback()  # rollback a possible transaction
                     except Exception:

pyproject.toml

@@ -66,18 +66,18 @@ line-length = 79
 target-version = "py37"
 
 [tool.ruff.mccabe]
-max-complexity = 31
+max-complexity = 32
 
 [tool.ruff.pylint]
-allow-magic-value-types = ["int", "str"]
-max-args = 12
-max-branches = 41
-max-statements = 95
+max-args = 15
+max-branches = 50
+max-statements = 100
 
 [tool.ruff.per-file-ignores]
 "docs/*" = [
-  "INP001"  # allow stand-alone scripts
+  "INP001",  # allow stand-alone scripts
 ]
 "tests/*" = [
-  "S101"  # allow assert statements
+  "PLR2004",  # allow magic values
+  "S101",  # allow assert statements
 ]