Update parameter type checking

Update parameter type checking in the `CiscoSparkAPI` class.

Timeouts should be in intger seconds (not float).

`check_type()` should be able to recieve a single type as part of the `acceptable_types` parameter; convert it to a single element tuple to make the error reporting code work.

Author: cmlccie

ciscosparkapi/__init__.py

@@ -51,6 +51,8 @@
     RestSession as _RestSession,
 )
 
+from .utils import check_type
+
 
 __author__ = "Chris Lunsford"
 __author_email__ = "chrlunsf@cisco.com"
@@ -152,15 +154,19 @@ def __init__(self, access_token=None, base_url=DEFAULT_BASE_URL,
             CiscoSparkAPI: A new CiscoSparkAPI object.
 
         Raises:
-            AssertionError: If the parameter types are incorrect.
+            TypeError: If the parameter types are incorrect.
             ciscosparkapiException: If an access token is not provided via the
                 access_token argument or SPARK_ACCESS_TOKEN environment
                 variable.
 
         """
-        assert access_token is None or isinstance(access_token, basestring)
+        check_type(access_token, basestring)
+        check_type(base_url, basestring)
+        check_type(single_request_timeout, int)
+        check_type(wait_on_rate_limit, bool)
+
         env_access_token = os.environ.get(ACCESS_TOKEN_ENVIRONMENT_VARIABLE)
-        access_token = access_token if access_token else env_access_token
+        access_token = access_token or env_access_token
         if not access_token:
             error_message = "You must provide an Spark access token to " \
                             "interact with the Cisco Spark APIs, either via " \

ciscosparkapi/restsession.py

@@ -41,7 +41,7 @@
 
 
 # Module Constants
-DEFAULT_SINGLE_REQUEST_TIMEOUT = 60.0
+DEFAULT_SINGLE_REQUEST_TIMEOUT = 60
 DEFAULT_WAIT_ON_RATE_LIMIT = True
 
 

ciscosparkapi/utils.py

@@ -120,6 +120,9 @@ def check_type(o, acceptable_types, may_be_none=True):
             object is not an instance of one of the acceptable types.
 
     """
+    if not isinstance(acceptable_types, tuple):
+        acceptable_types = (acceptable_types,)
+
     if may_be_none and o is None:
         # Object is None, and that is OK!
         pass