Minor changes to attachment actions

Author: cmlccie

webexteamssdk/api/attachment_actions.py

@@ -33,14 +33,10 @@
 from builtins import *
 
 from past.builtins import basestring
-from requests_toolbelt import MultipartEncoder
 
-from ..generator_containers import generator_container
+from ..models.immutable import AttachmentAction
 from ..restsession import RestSession
-from ..utils import (
-    check_type, dict_from_items_with_values, is_local_file, is_web_url,
-    open_local_file,
-)
+from ..utils import check_type, dict_from_items_with_values
 
 
 API_ENDPOINT = 'attachment/actions'
@@ -56,7 +52,7 @@ class AttachmentActionsAPI(object):
     """
 
     def __init__(self, session, object_factory):
-        """Init a new AttachmentActionsAPI object with the provided RestSession.
+        """Initialize a new AttachmentActionsAPI object.
 
         Args:
             session(RestSession): The RESTful session object to be used for
@@ -71,21 +67,20 @@ def __init__(self, session, object_factory):
         self._session = session
         self._object_factory = object_factory
 
-    def create(self, type=None, messageId=None, inputs=None,
-               **request_parameters):
-        """Create an attachment action.
+    def create(self, type, messageId, inputs, **request_parameters):
+        """Create a new attachment action.
 
         Args:
-            type(attachment action enum): The type of attachment action.
-            messageId(basestring): The ID of parent message the attachment
-                action is to be performed on.
-            inputs(dict): inputs to attachment fields
+            type(basestring): The type of action to perform.
+            messageId(basestring): The ID of the message which contains the
+                attachment.
+            inputs(dict): The attachment action's inputs.
             **request_parameters: Additional request parameters (provides
                 support for parameters that may be added in the future).
 
         Returns:
-            Attachment action: A attachment action object with the details
-            of the created attachment action.
+            AttachmentAction: A attachment action object with the details of
+            the created attachment action.
 
         Raises:
             TypeError: If the parameter types are incorrect.
@@ -95,7 +90,6 @@ def create(self, type=None, messageId=None, inputs=None,
                 contain a valid URL or path to a local file.
 
         """
-
         check_type(type, basestring)
         check_type(messageId, basestring)
         check_type(inputs, dict)

webexteamssdk/models/immutable.py

@@ -178,6 +178,10 @@ class AccessToken(ImmutableData, AccessTokenBasicPropertiesMixin):
     """Webex Teams Access-Token data model."""
 
 
+class AttachmentAction(ImmutableData, AttachmentActionBasicPropertiesMixin):
+    """Webex Attachment Actions data model"""
+
+
 class Event(ImmutableData, EventBasicPropertiesMixin):
     """Webex Teams Event data model."""
 
@@ -231,10 +235,6 @@ class Webhook(ImmutableData, WebhookBasicPropertiesMixin):
     """Webex Teams Webhook data model."""
 
 
-class AttachmentAction(ImmutableData, AttachmentActionBasicPropertiesMixin):
-    """Webex Attachment Actions data model"""
-
-
 class WebhookEvent(ImmutableData, WebhookEventBasicPropertiesMixin):
     """Webex Teams Webhook-Events data model."""
 

webexteamssdk/models/mixins/attachment_action.py

@@ -40,22 +40,22 @@ class AttachmentActionBasicPropertiesMixin(object):
 
     @property
     def id(self):
-        """The unique identifier for the attachment action."""
+        """A unique identifier for the action."""
         return self._json_data.get('id')
 
     @property
     def personId(self):
-        """The ID of the person who performed the attachment action."""
+        """The ID of the person who performed the action."""
         return self._json_data.get('personId')
 
     @property
     def roomId(self):
-        """The room ID of the attachment action."""
+        """The ID of the room the action was performed within."""
         return self._json_data.get('roomId')
 
     @property
     def type(self):
-        """The type of attachment action.
+        """The type of action performed.
 
         Attachment action enum:
             'submit': submit filled in inputs
@@ -64,17 +64,17 @@ def type(self):
 
     @property
     def messageId(self):
-        """The ID of parent message the attachment action was performed on."""
+        """The parent message the attachment action was performed on."""
         return self._json_data.get('messageId')
 
     @property
     def inputs(self):
-        """The attachment action's inputs"""
+        """The action's inputs."""
         return self._json_data('inputs')
 
     @property
     def created(self):
-        """The date and time the attachment action was created."""
+        """The date and time the action was created."""
         created = self._json_data.get('created')
         if created:
             return WebexTeamsDateTime.strptime(created)