Update Rooms API

- Set default value for `max=` parameter on the rooms.list() method.
- Make `title` a required parameter for the rooms.update() method.

Author: cmlccie

webexteamssdk/api/rooms.py

@@ -73,7 +73,7 @@ def __init__(self, session, object_factory):
         self._object_factory = object_factory
 
     @generator_container
-    def list(self, teamId=None, type=None, sortBy=None, max=None,
+    def list(self, teamId=None, type=None, sortBy=None, max=100,
              **request_parameters):
         """List rooms.
 
@@ -189,7 +189,7 @@ def get(self, roomId):
         # Return a room object created from the response JSON data
         return self._object_factory(OBJECT_TYPE, json_data)
 
-    def update(self, roomId, title=None, **request_parameters):
+    def update(self, roomId, title, **request_parameters):
         """Update details for a room, by ID.
 
         Args:
@@ -207,7 +207,7 @@ def update(self, roomId, title=None, **request_parameters):
 
         """
         check_type(roomId, basestring)
-        check_type(roomId, basestring, optional=True)
+        check_type(roomId, basestring)
 
         put_data = dict_from_items_with_values(
             request_parameters,

webexteamssdk/models/mixins/room.py

@@ -41,12 +41,12 @@ class RoomBasicPropertiesMixin(object):
     @property
     def id(self):
         """A unique identifier for the room."""
-        return self._json_data.get('id')
+        return self._json_data.get("id")
 
     @property
     def title(self):
         """A user-friendly name for the room."""
-        return self._json_data.get('title')
+        return self._json_data.get("title")
 
     @property
     def type(self):
@@ -57,22 +57,22 @@ def type(self):
 
             `group`: Group room
         """
-        return self._json_data.get('type')
+        return self._json_data.get("type")
 
     @property
     def isLocked(self):
         """Whether the room is moderated (locked) or not."""
-        return self._json_data.get('isLocked')
+        return self._json_data.get("isLocked")
 
     @property
     def teamId(self):
         """The ID for the team with which this room is associated."""
-        return self._json_data.get('teamId')
+        return self._json_data.get("teamId")
 
     @property
     def lastActivity(self):
-        """The date and time of the room's last activity."""
-        last_activity = self._json_data.get('lastActivity')
+        """The date and time of the room"s last activity."""
+        last_activity = self._json_data.get("lastActivity")
         if last_activity:
             return WebexTeamsDateTime.strptime(last_activity)
         else:
@@ -81,18 +81,18 @@ def lastActivity(self):
     @property
     def creatorId(self):
         """The ID of the person who created this room."""
-        return self._json_data.get('creatorId')
-
-    @property
-    def ownerId(self):
-        """The ID of the organization which owns this room."""
-        return self._json_data.get('ownerId')
+        return self._json_data.get("creatorId")
 
     @property
     def created(self):
         """The date and time the room was created."""
-        created = self._json_data.get('created')
+        created = self._json_data.get("created")
         if created:
             return WebexTeamsDateTime.strptime(created)
         else:
             return None
+
+    @property
+    def ownerId(self):
+        """The ID of the organization which owns this room."""
+        return self._json_data.get("ownerId")